Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close db write batch after use #4379

Merged
merged 2 commits into from
May 22, 2019

Conversation

Stumble
Copy link
Contributor

@Stumble Stumble commented May 20, 2019

db write batch should be closed.


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #4379 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4379      +/-   ##
==========================================
+ Coverage   58.08%   58.09%   +0.01%     
==========================================
  Files         235      235              
  Lines       14881    14882       +1     
==========================================
+ Hits         8643     8646       +3     
+ Misses       5608     5606       -2     
  Partials      630      630

@codecov
Copy link

codecov bot commented May 20, 2019

Codecov Report

Merging #4379 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4379      +/-   ##
==========================================
+ Coverage   58.08%   58.08%   +<.01%     
==========================================
  Files         235      235              
  Lines       14881    14882       +1     
==========================================
+ Hits         8643     8644       +1     
  Misses       5608     5608              
  Partials      630      630

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth creating a small issue for this and referencing it in a pending log entry. Nevertheless, ACK 👍

@Stumble
Copy link
Contributor Author

Stumble commented May 20, 2019

issue created: #4381

@alexanderbez
Copy link
Contributor

Thanks @Stumble! Can you also add a pending log entry?

$ clog add improvements sdk

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACKd - pending clog file

@Stumble
Copy link
Contributor Author

Stumble commented May 22, 2019

@alexanderbez @alessio clog add improvements sdk executed, not sure whether the file generated is expected. btw, nice tool.

@alessio alessio merged commit 65be4db into cosmos:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants