-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close db write batch after use #4379
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4379 +/- ##
==========================================
+ Coverage 58.08% 58.09% +0.01%
==========================================
Files 235 235
Lines 14881 14882 +1
==========================================
+ Hits 8643 8646 +3
+ Misses 5608 5606 -2
Partials 630 630 |
Codecov Report
@@ Coverage Diff @@
## master #4379 +/- ##
==========================================
+ Coverage 58.08% 58.08% +<.01%
==========================================
Files 235 235
Lines 14881 14882 +1
==========================================
+ Hits 8643 8644 +1
Misses 5608 5608
Partials 630 630 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth creating a small issue for this and referencing it in a pending log entry. Nevertheless, ACK 👍
issue created: #4381 |
Thanks @Stumble! Can you also add a pending log entry?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACKd - pending clog
file
@alexanderbez @alessio |
db write batch should be closed.
For Admin Use: