Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Support "unknown commands" for subcommands #4465

Merged
merged 4 commits into from
Jun 4, 2019
Merged

R4R: Support "unknown commands" for subcommands #4465

merged 4 commits into from
Jun 4, 2019

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented May 31, 2019

Fixes #4284
Now prints:

gaiacli query distr comission --trust-node cosmos1234
ERROR: unknown command "comission" for "distr"

Did you mean this?
	commission

Adds custom argument validation for subcommands with subcommands. Doesn't affect "query" or "tx" subcommands since they reside in gaia repo. All flags except help are disabled for these commands

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@52be449). Click here to learn what that means.
The diff coverage is 76.47%.

@@            Coverage Diff            @@
##             master    #4465   +/-   ##
=========================================
  Coverage          ?   54.63%           
=========================================
  Files             ?      250           
  Lines             ?    16093           
  Branches          ?        0           
=========================================
  Hits              ?     8792           
  Misses            ?     6653           
  Partials          ?      648

@colin-axner colin-axner changed the title WIP: Support "unknown commands" for subcommands R4R: Support "unknown commands" for subcommands Jun 3, 2019
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestedACK

Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

@alessio alessio merged commit 6e2f5f3 into cosmos:master Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support "unknown command" for subcommands.
4 participants