Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find a way to seal governance codec #4473

Closed
rigelrozanski opened this issue Jun 3, 2019 · 1 comment
Closed

find a way to seal governance codec #4473

rigelrozanski opened this issue Jun 3, 2019 · 1 comment
Labels

Comments

@rigelrozanski
Copy link
Contributor

rigelrozanski commented Jun 3, 2019

ref #4451 (comment)
CC @alexanderbez, @fedekunze

it would be good to determine a way by which the governance codec could be sealed, currently it needs to remain unsealed such that other modules can register their custom proposal type with the gov codec... maybe each proposal type could also pass in a custom codec? ideas? this is a low priority issue I think

@alexanderbez
Copy link
Contributor

Hmm, yeah this is a good point and particular only to governance atm. Imho, the plan is to ditch amino in the near future so this may not even be a concern by then. Until then, it's tricky because we cannot guarantee order of registrations because that depends on the order of when/which files are imported or loaded for the fist time. Regardless, I do think this is low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants