Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CORS flag, it's gone. #4525

Merged
merged 2 commits into from
Jun 10, 2019
Merged

Remove CORS flag, it's gone. #4525

merged 2 commits into from
Jun 10, 2019

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Jun 10, 2019

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 10, 2019

Codecov Report

Merging #4525 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4525   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files         256      256           
  Lines       16165    16165           
=======================================
  Hits         8648     8648           
  Misses       6870     6870           
  Partials      647      647

@alessio alessio requested review from sabau and fedekunze June 10, 2019 15:43
@alessio alessio merged commit 8cc708b into master Jun 10, 2019
@alessio alessio deleted the alessio/remove-cors-flag branch June 10, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants