Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Un)DelegateCoins returned tags not used anywhere #4526

Closed
4 tasks
fedekunze opened this issue Jun 10, 2019 · 2 comments
Closed
4 tasks

(Un)DelegateCoins returned tags not used anywhere #4526

fedekunze opened this issue Jun 10, 2019 · 2 comments
Labels
C:x/bank good first issue

Comments

@fedekunze
Copy link
Collaborator

Summary of Bug

I did a quick search and the bank keeper's DelegateCoins and UndelegateCoins returned tags are not used in any of the instances that call that function.

Consider removing the returned tags or using them.

DelegateCoins(ctx sdk.Context, addr sdk.AccAddress, amt sdk.Coins) (sdk.Tags, sdk.Error)
UndelegateCoins(ctx sdk.Context, addr sdk.AccAddress, amt sdk.Coins) (sdk.Tags, sdk.Error)

cc: @alexanderbez @alessio

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze fedekunze changed the title (Un)DelegateCoin returned tags not used anywhere (Un)DelegateCoins returned tags not used anywhere Jun 10, 2019
@alexanderbez
Copy link
Contributor

I haven't fully looked into the scope of the calls, but my initial instinct tells me that bank should not be returning tags here but rather upstream in staking where the actual message is handled.

@fedekunze
Copy link
Collaborator Author

closed via #4387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/bank good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexanderbez @fedekunze