R4R: use expected keeper for bank module #4584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colin-axner
requested review from
alessio,
alexanderbez,
jackzampolin and
rigelrozanski
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4584 +/- ##
==========================================
+ Coverage 52.65% 52.66% +0.01%
==========================================
Files 263 263
Lines 16463 16463
==========================================
+ Hits 8669 8671 +2
+ Misses 7146 7144 -2
Partials 648 648 |
alexanderbez
suggested changes
Jun 19, 2019
There was a problem hiding this comment.
Looks great @colin-axner, thanks!. Left a minor note in the expected keeper.
fedekunze
approved these changes
Jun 19, 2019
Co-Authored-By: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
alexanderbez
suggested changes
Jun 20, 2019
| @@ -5,7 +5,7 @@ import ( | |||
| "time" | |||
|
|
|||
| sdk "github.com/cosmos/cosmos-sdk/types" | |||
| "github.com/cosmos/cosmos-sdk/x/auth" | |||
| authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" | |||
There was a problem hiding this comment.
These shouldn't use authtypes, but rather bank types (types.AccountKeeper).
There was a problem hiding this comment.
so add an account interface? authtypes is only used for Account and VestingAccount
There was a problem hiding this comment.
@colin-axner yes -- in x/bank/internal/types/expected_keepers.go implement the Account interface.
alexanderbez
changed the base branch from
master
to
bez/4576-bank-expected-keeper
alexanderbez
approved these changes
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/)Added a relevant changelog entry:
clog add [section] [stanza] [message]rereviewed
Files changedin the github PR explorerFor Admin Use: