Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specs Updates #4628

Closed
10 tasks
fedekunze opened this issue Jun 26, 2019 · 6 comments
Closed
10 tasks

Specs Updates #4628

fedekunze opened this issue Jun 26, 2019 · 6 comments

Comments

@fedekunze
Copy link
Collaborator

fedekunze commented Jun 26, 2019

Summary

Specs are very outdated and currently don't reflect the current status of the code. Also, not all of them follow the standard defined in SPEC-SPEC.md.

Proposal

Some of the specs that need to be updated:

  • Auth: re/move keepers file, define AnteHandler on concepts, etc
  • Bank: re/move keepers file, update msgs, missing concepts, etc
  • Staking: missing slashing section
  • Distribution : Update state and keys
  • Gov : Add new proposal types, update state
  • Slashing : move Tombstone concepts

Note: this list not final. Feel free to create an issue for each item or update it.

cc: @alexanderbez @jackzampolin


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

Thanks @fedekunze!

@rigelrozanski
Copy link
Contributor

Yup just noticed some missing stuff in distribution 👍

@karzak
Copy link
Contributor

karzak commented Jul 5, 2019

I would recommend updating the shortcomings section of the distribution spec. It’s unclear from reading it which of the concerns outlined are outdated now that F1 has been implemented and which are still relevant. For example #2764 is linked in that section, but has since been closed.

@alexanderbez alexanderbez mentioned this issue Aug 12, 2019
5 tasks
@karzak
Copy link
Contributor

karzak commented Nov 19, 2019

In the gov spec it says that proposals are executed immediately if 2/3 of InitTotalVotingPower votes yes. This isn't implemented and should be removed.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tac0turtle
Copy link
Member

closing this as the specs have been updated a few times

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants