-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It should be possible to see the amount of the auto-withdraw that happens on delegate and undelegate txs #4728
Comments
I think its fixed with the events added to 0.36.0 here: |
Yes, you'll be able to see all these events through the new events system 👍 |
I see that the information isn't available in the events in version 0.36. {"height":"105","txhash":"D3DFF4AD99142529D9E4480239ACF2BBFDC36522353A8D677AF44E3DF62FBEA8","raw_log":"[{"msg_index":0,"success":true,"log":""}]","logs":[{"msg_index":0,"success":true,"log":""}],"gas_wanted":"200000","gas_used":"100447","events":[{"type":"delegate","attributes":[{"key":"validator","value":"cosmosvaloper1jp6wup6v8s6dqxdeq2epwt8u6pxpw3pf37hgru"},{"key":"amount","value":"100000"}]},{"type":"message","attributes":[{"key":"action","value":"delegate"},{"key":"sender","value":"cosmos1jv65s3grqf6v6jl3dp4t6c9t9rk99cd88lyufl"},{"key":"module","value":"staking"},{"key":"sender","value":"cosmos1y3qhvhmnd4cae5zfj9w48je3pfkckn0fm99g99"}]},{"type":"transfer","attributes":[{"key":"recipient","value":"cosmos1y3qhvhmnd4cae5zfj9w48je3pfkckn0fm99g99"}]}],"tx":{"type":"cosmos-sdk/StdTx","value":{"msg":[{"type":"cosmos-sdk/MsgDelegate","value":{"delegator_address":"cosmos1y3qhvhmnd4cae5zfj9w48je3pfkckn0fm99g99","validator_address":"cosmosvaloper1jp6wup6v8s6dqxdeq2epwt8u6pxpw3pf37hgru","amount":{"denom":"stake","amount":"100000"}}}],"fee":{"amount":[],"gas":"200000"},"signatures":[{"pub_key":{"type":"tendermint/PubKeySecp256k1","value":"AyKLozcl3YXspKx3hyorGJMnAGqoW9BBZB4m0OJZXr35"},"signature":"n5G+GFldmCPeqMPs68EadXscgztv+9ux2f+vNsoegx9Ce9GavcHUWRmCQNFX0ngb0cqwjLFagEHMWQo6echDeA=="}],"memo":""}},"timestamp":"2019-07-23T14:17:49Z"} |
@UdiIlan indeed! We are emitting the event, but just not the amount. I'll update this accordingly. Thank you! |
@alexanderbez do you think that the amount can be added any time soon? |
Summary of Bug
When bonding or unbonding coins the potential outstanding reward from the delegator gets auto-withdrawn to the delegator or the set reward address.
This auto-withdrawn is not shown in any form on the
MsgDelegate
orMsgUndelegate
Tx.This makes it very difficult to know how much was withdrawn while delegating or undelegating.
I would propose to add the same tag to the tx that is already in use when withdrawing rewards also to the
MsgDelegate
andMsgUndelegate
txs.Here an example of the tag:
https://hubble.figment.network/cosmos/chains/cosmoshub-2/blocks/1074949/transactions/CD89DBC2AA8FA8AB118CF7C1CF4A54D800E50341D3D2E16DD0B0076F1A8173DE?format=json
{"key":"rewards","value":"13618319uatom"}
Interestingly the following txs has non such tag:
https://hubble.figment.network/cosmos/chains/cosmoshub-2/blocks/470256/transactions/2A5B98E9077B28E9429A279825667F424BB49ED0BA0443996DA6B6022E7CDD50?format=json
I am not sure why could it be that the tx was just done before (#3850) was in place?
Version
Current mainnet.
Steps to Reproduce
For Admin Use
The text was updated successfully, but these errors were encountered: