Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update x/auth to match module spec #4760

Merged
merged 11 commits into from
Jul 29, 2019
Merged

update x/auth to match module spec #4760

merged 11 commits into from
Jul 29, 2019

Conversation

fedekunze
Copy link
Collaborator

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. WIP labels Jul 22, 2019
@codecov
Copy link

codecov bot commented Jul 24, 2019 •
edited
Loading

Codecov Report

Merging #4760 into master will increase coverage by 0.04%.
The diff coverage is 60.37%.

@@            Coverage Diff             @@
##           master    #4760      +/-   ##
==========================================
+ Coverage   50.46%   50.51%   +0.04%     
==========================================
  Files         288      288              
  Lines       18571    18517      -54     
==========================================
- Hits         9371     9353      -18     
+ Misses       8511     8479      -32     
+ Partials      689      685       -4

@fedekunze fedekunze added R4R and removed WIP labels Jul 25, 2019
@fedekunze fedekunze marked this pull request as ready for review July 25, 2019 13:29
@fedekunze fedekunze requested a review from colin-axner July 25, 2019 18:56
colin-axner
colin-axner reviewed Jul 25, 2019
View reviewed changes
x/auth/keeper/querier_test.go Show resolved Hide resolved
x/auth/ante/ante.go Outdated Show resolved Hide resolved
alexanderbez
alexanderbez suggested changes Jul 25, 2019
View reviewed changes
client/cmd_test.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
x/auth/keeper/test_common.go Outdated Show resolved Hide resolved
@fedekunze fedekunze requested a review from alexanderbez July 26, 2019 09:39
colin-axner
colin-axner approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alexanderbez
alexanderbez approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit fb3e0af into master Jul 29, 2019
@alexanderbez alexanderbez deleted the fedekunze/update-auth branch July 29, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

@alessio alessio Awaiting requested review from alessio

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

Assignees
No one assigned
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedekunze @alexanderbez @colin-axner