Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split core simulation into multiple functions #5052

Closed
rigelrozanski opened this issue Sep 17, 2019 · 3 comments
Closed

Split core simulation into multiple functions #5052

rigelrozanski opened this issue Sep 17, 2019 · 3 comments
Labels
C:Simulations help wanted Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@rigelrozanski
Copy link
Contributor

Followup to #2736 (comment)

within simulation (x/mock/simulation/simulation.go) there is a "master" simulation function SimulateFromSeed - this function is ~200LOC and should probably be broken up into 3-5 functions for better code comprehension, I imagine the contents of that giant loop should be broken out for example.

CC @fedekunze

@fedekunze
Copy link
Collaborator

That’s the case for the simulation module correct (I believe there’s a TODO). We should leave mock as is bc we want to deprecate it in the future

@jackzampolin jackzampolin added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Sep 17, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 5, 2020
@fedekunze fedekunze reopened this Jul 12, 2020
@fedekunze fedekunze added this to the v0.41 milestone Jul 12, 2020
@aaronc aaronc modified the milestones: v0.41, v0.42 Jan 6, 2021
@tac0turtle tac0turtle removed the pinned label May 9, 2022
@tac0turtle
Copy link
Member

simulator is being rewritten with bette rux in mind. closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Simulations help wanted Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Development

No branches or pull requests

5 participants