ICS04: Unordered channels for Packet receiving

[mossid]

Channel types are defined as ChannelOrder under Definitions in ICS04:

enum ChannelOrder {
  ORDERED,
  UNORDERED,
}

and the packet submission works differently on the different channel ordering types:

function recvPacket(
  packet: OpaquePacket,
  proof: CommitmentProof,
  proofHeight: uint64,
  acknowledgement: bytes): Packet {
    ...
  
    if (acknowledgement.length > 0 || channel.order === UNORDERED)
      provableStore.set(
        packetAcknowledgementPath(packet.destPort, packet.destChannel, packet.sequence),
        hash(acknowledgement)
      )

    if (channel.order === ORDERED) {
      nextSequenceRecv = provableStore.get(nextSequenceRecvPath(packet.destPort, packet.destChannel))
      abortTransactionUnless(packet.sequence === nextSequenceRecv)
      nextSequenceRecv = nextSequenceRecv + 1
      provableStore.set(nextSequenceRecvPath(packet.destPort, packet.destChannel), nextSequenceRecv)
    }

    // return transparent packet
    return packet
}

The current implementation defines only ordered channels. We need to add ordering logic in the channel implementation and modify Object.Receive() function to match with recvPacket.

[jackzampolin]

Sounds like @fedekunze has this in the current PRs

[fedekunze]

Closed via #4548