Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS24 Identifier and Path validation #5209

Closed
4 tasks
fedekunze opened this issue Oct 16, 2019 · 3 comments
Closed
4 tasks

ICS24 Identifier and Path validation #5209

fedekunze opened this issue Oct 16, 2019 · 3 comments
Assignees

Comments

@fedekunze
Copy link
Collaborator

Summary

Implement a generalized Identifier and Path validation functions as defined in ICS24.

This is required by most of the IBC msg validation functions.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze fedekunze added this to the IBC Implementation & Integration milestone Oct 16, 2019
@cwgoes
Copy link
Contributor

cwgoes commented Oct 16, 2019

I assume you mean validation of client, connection, and channel identifiers. Those are separate; they don't need to perform the same validation (but they can).

I think, for now, it's fine if those three all perform the same simple checks:

  • Length bounds (at least 10 characters, at most 20 characters - to prevent name squatting)
  • Character inclusion (alphanumeric only, maybe prohibit uppercase)

@AdityaSripal AdityaSripal self-assigned this Oct 16, 2019
@fedekunze
Copy link
Collaborator Author

@AdityaSripal FYI the PR should be rebased to joon/ics-23-implementation

@fedekunze fedekunze modified the milestones: IBC Implementation & Integration, IBC Implementation Dec 10, 2019
@fedekunze
Copy link
Collaborator Author

Closed via #5229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants