Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS 05: Transfering port spec #5215

Closed
tnachen opened this issue Sep 25, 2019 · 5 comments
Closed

ICS 05: Transfering port spec #5215

tnachen opened this issue Sep 25, 2019 · 5 comments
Assignees

Comments

@tnachen
Copy link
Contributor

tnachen commented Sep 25, 2019

Currently in the ICS 05 "Transferring ownership of a port" it specifies that the intention of the transfer is to transfer the ownership of a port from one module (aka owner) to another. However, in the reference code it simply copies the Port and therefore both modules ends up with ownership of the same port.
Is this intended for two or more modules to share the same port? Or we actually want to fully transfer the ownership from one owner to another?

@cwgoes
Copy link
Contributor

cwgoes commented Sep 25, 2019

The intention is indeed to change ownership of the port from the transferring module to the transferee.

What reference code are you referring to that does otherwise?

@cwgoes
Copy link
Contributor

cwgoes commented Oct 10, 2019

cc @mossid did we fix this in the implementation yet? It should look like store keys in the SDK.

@cwgoes
Copy link
Contributor

cwgoes commented Oct 14, 2019

@mossid Please close when this has been fixed or let me know if you need help.

@cwgoes cwgoes transferred this issue from cosmos/ibc Oct 17, 2019
@cwgoes
Copy link
Contributor

cwgoes commented Oct 17, 2019

(transferred to the SDK as this is an implementation issue)

(however if you would like clarifications in the spec do let me know anytime!)

@fedekunze
Copy link
Collaborator

Closing this as it's already covered on #5191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants