Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashing and Evidence Module Relationship #5296

Closed
3 of 4 tasks
alexanderbez opened this issue Nov 8, 2019 · 3 comments · Fixed by #5299
Closed
3 of 4 tasks

Slashing and Evidence Module Relationship #5296

alexanderbez opened this issue Nov 8, 2019 · 3 comments · Fixed by #5299

Comments

@alexanderbez
Copy link
Contributor

alexanderbez commented Nov 8, 2019

Summary

With the advent and introduction of the new x/evidence module, there is some natural overlap with the existing x/slashing module. Namely, the handling of evidence. Currently, x/slashing handles the following:

  1. Slashing parameters
  2. Liveness tracking
  3. Evidence handling (equivocation only)
  4. Slashing business logic

Note, the actual slashing is done by the x/staking module.

Problem Definition

Modules should be primarily isolated in function and utility (like Linux packages).

Proposal

I think we can reduce or remove completely this overlap by simply having the x/evidence module deal with (3). Then, x/slashing primarily deals with liveness tracking, slashing parameters and slashing business logic!

Thoughts @cwgoes @zmanian @rigelrozanski @fedekunze @AdityaSripal ?


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@fedekunze
Copy link
Collaborator

++

@alexanderbez
Copy link
Contributor Author

I'll start work on this if there are no objections.

@alexanderbez alexanderbez self-assigned this Nov 8, 2019
@cwgoes
Copy link
Contributor

cwgoes commented Nov 8, 2019

Concept ACK, proposal ACK. No objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants