Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add String() method to GasMeter #6128

Closed
4 tasks
fedekunze opened this issue May 3, 2020 · 2 comments · Fixed by #6137
Closed
4 tasks

Add String() method to GasMeter #6128

fedekunze opened this issue May 3, 2020 · 2 comments · Fixed by #6137

Comments

@fedekunze
Copy link
Collaborator

Summary

Add String() function to GasMeter Interface

Problem Definition

fmt.Println(ctx.GasMeter()) returns a string that is hard to grasp since it doesn't reference the fields (eg: &{22000 21272})

The expected value should look something like:

GasMeter:
    GasLimit: 22000
    GasConsumed: 21272

Proposal

Add String() function to GasMeter interface and to the concrete types that implement it


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@Sladuca
Copy link
Contributor

Sladuca commented May 3, 2020

Hi, I'd like to take this on provided nobody else has.

@alexanderbez
Copy link
Contributor

Yes please @Sladuca :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants