Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade module tx commands not set #6284

Closed
4 tasks
RiccardoM opened this issue May 27, 2020 · 0 comments · Fixed by #6285 or #6840
Closed
4 tasks

Upgrade module tx commands not set #6284

RiccardoM opened this issue May 27, 2020 · 0 comments · Fixed by #6285 or #6840

Comments

@RiccardoM
Copy link
Contributor

Summary of Bug

The x/upgrade module does not have its tx commands initialized properly.

Version

7cd0cab

Steps to Reproduce

Try running any of the x/upgrade module CLI commands related to the transactions:

  • tx upgrade software-upgrade
  • tx upgrade cancel-software-upgrade

Fix

The fix should be pretty easy to implement and consists in registering them inside the x/upgrade module module.go file:

// GetTxCmd returns the transaction commands for this module
func (AppModuleBasic) GetTxCmd(ctx context.CLIContext) *cobra.Command {
  txCmd := &cobra.Command{
    Use:   "upgrade",
    Short: "Upgrade transaction subcommands",
    }
  txCmd.AddCommand(flags.PostCommands(
    cli.NewCmdSubmitUpgradeProposal(ctx),
    cli.NewCmdSubmitCancelUpgradeProposal(ctx),
  )...)
  return txCmd
}

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants