Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed genesis-transaction to declare-candidacy at genesis for gaia #659

Closed
adrianbrink opened this issue Mar 19, 2018 · 5 comments
Closed

Comments

@adrianbrink
Copy link
Contributor

No description provided.

@cwgoes
Copy link
Contributor

cwgoes commented Apr 27, 2018

Superseded by #889.

@cwgoes cwgoes closed this as completed Apr 27, 2018
@rigelrozanski
Copy link
Contributor

Actually not the case @cwgoes - This issue refers to the genesis transaction actually being signed... right now we've created a genesis-transaction type but it has no regard for being signed with a pubkey which is associated with a genesis account

@rigelrozanski rigelrozanski reopened this Apr 27, 2018
@rigelrozanski rigelrozanski changed the title genesis.json includes signed BondMsg that bonds from a genesis account Signed genesis-transaction to declare-candidacy at genesis for gaia Apr 27, 2018
@rigelrozanski
Copy link
Contributor

More on this issue I think it would be really cool if we could re-use the majority of the transaction logic from the message hander FOR a genesis transaction too.. probably achievable, just need to look into it a bit more

@cwgoes
Copy link
Contributor

cwgoes commented Apr 27, 2018

Ah sorry - thanks for the clarification.

Agreed on reusing logic where possible, less bug-prone than implementing a special case.

@alexanderbez
Copy link
Contributor

Closing in favor of #1890.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants