-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arbitrary initial height #7018
Comments
We probably need to write up an ADR for how to support this and the expected use-cases. Thanks @erikgrinaker. |
The primary use-case would be for e.g. the Cosmos Hub upgrade to Stargate to continue from the same block height as the previous chain, see RFC-002 for details. |
@zmanian do we want to do this for stargate? We're gonna need to get at the very least:
|
Yeah I want this for stargate and I willing to help with above |
tm-rc3 has been released, correct @erikgrinaker? I'm thinking this might be easier than I thought -- I think we can just pass the last version (height) from |
Yes, rc3 is out. Not sure what you mean by passing from BaseApp; Tendermint/genesis specifies the initial height, not the app. |
Nope it runs. I had a testnet running and zakis testnet is with my wip branch |
@erikgrinaker right, I meant we load that height from the request. |
In discussing with @marbar3778, there are basically two things we need to do:
|
Yes, this is what I also had in mind as the core components to look at. I believe the latter will be trivial, whereas the former we'll need to maybe load that height at the very beginning of |
Summary
In tendermint/tendermint#5191 (will be released in 0.34.0-rc3), Tendermint added support for starting from an arbitrary initial height, given to the application via
RequestInitChain.initial_height
. IAVL added support for starting from an arbitrary version in cosmos/iavl#299 (released in 0.15.0-rc1). The SDK will need to configure itself accordingly.For Admin Use
The text was updated successfully, but these errors were encountered: