Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simd: init fails #7026

Closed
4 tasks
tac0turtle opened this issue Aug 12, 2020 · 11 comments · Fixed by #7037
Closed
4 tasks

simd: init fails #7026

tac0turtle opened this issue Aug 12, 2020 · 11 comments · Fixed by #7037

Comments

@tac0turtle
Copy link
Member

Summary of Bug

Running make build-simd && ./build/simd init test --chain-id tts I get error:

Error: open config/node_key.json: no such file or directory

Version

Master

Steps to Reproduce

make build-simd && ./build/simd init test --chain-id tts


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

@jgimeno this recently worked. Could you take a look at this when you have a chance please?

@jgimeno
Copy link
Contributor

jgimeno commented Aug 12, 2020

Absolutely! Looking at it right now.

@jgimeno
Copy link
Contributor

jgimeno commented Aug 12, 2020

The problem is this change:

withProtoJSON(genutilcli.InitCmd(simapp.ModuleBasics, simapp.DefaultNodeHome)),

That function bypasses the rootCmd PersistentPreRun, checking how to make it work as expected.

@jgimeno
Copy link
Contributor

jgimeno commented Aug 12, 2020

I think that PersistenPreRun is set inside of rootCmd.AddCommand and because it detects it has another one set it just not receive it.

@alexanderbez
Copy link
Contributor

Maybe we don't need to wrap it with withProtoJSON? Thoughts @aaronc? When can we remove withProtoJSON?

@aaronc
Copy link
Member

aaronc commented Aug 12, 2020

It's removed in #6859. It's almost ready

@jgimeno
Copy link
Contributor

jgimeno commented Aug 13, 2020

Shall we just wait for #6859?

@aaronc
Copy link
Member

aaronc commented Aug 13, 2020

I'm hoping to get that merged this morning. @sahith-narahari is reviewing now

@tac0turtle
Copy link
Member Author

tac0turtle commented Aug 13, 2020

new error since #6859 merge:

Error: Failed to marshall default genesis state: cannot protobuf JSON encode unsupported type: map[string]json.RawMessage

should something be setup in ci to avoid this?

@aaronc
Copy link
Member

aaronc commented Aug 13, 2020

Looks like there's a missing integration test. That's a simple fix. We've been switching those cases to use encoding/json instead of proto json

@amaury1093
Copy link
Contributor

I have a draft PR here: #7037. Will try to figure out an integration test too for it.

@mergify mergify bot closed this as completed in #7037 Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants