-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simd: init fails #7026
Comments
@jgimeno this recently worked. Could you take a look at this when you have a chance please? |
Absolutely! Looking at it right now. |
The problem is this change: cosmos-sdk/simapp/simd/cmd/root.go Line 82 in 20c5ee3
That function bypasses the rootCmd PersistentPreRun, checking how to make it work as expected. |
I think that PersistenPreRun is set inside of rootCmd.AddCommand and because it detects it has another one set it just not receive it. |
Maybe we don't need to wrap it with |
It's removed in #6859. It's almost ready |
Shall we just wait for #6859? |
I'm hoping to get that merged this morning. @sahith-narahari is reviewing now |
new error since #6859 merge:
should something be setup in ci to avoid this? |
Looks like there's a missing integration test. That's a simple fix. We've been switching those cases to use |
I have a draft PR here: #7037. Will try to figure out an integration test too for it. |
Summary of Bug
Running
make build-simd && ./build/simd init test --chain-id tts
I get error:Version
Master
Steps to Reproduce
make build-simd && ./build/simd init test --chain-id tts
For Admin Use
The text was updated successfully, but these errors were encountered: