Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nil checks in getter functions for ibc tm header #7880

Closed
4 tasks
colin-axner opened this issue Nov 10, 2020 · 0 comments · Fixed by #7916
Closed
4 tasks

Remove nil checks in getter functions for ibc tm header #7880

colin-axner opened this issue Nov 10, 2020 · 0 comments · Fixed by #7916
Assignees
@colin-axner
Labels
good first issue
Milestone
IBC 1.0 Implement...

Comments

@colin-axner
Copy link
Contributor

Summary

We do these checks in ValidateBasic. The getter should just return the value

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
good first issue
Projects
None yet
Milestone
IBC 1.0 Implementation Audit
Development

Successfully merging a pull request may close this issue.

Minor fixes for ibc tendermint cosmos/cosmos-sdk
1 participant
@colin-axner