-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove trailing whitespace in markdown #8112
Comments
this seems specific to markdown not code, am I missing something? |
I think @robert-zaremba means the markdown file(s). Yah, we should have a linter. It's annoying to keep fixing these in PRs. |
On tendermint we use githubs super linter: https://github.com/tendermint/tendermint/blob/master/.github/workflows/linter.yml with markdown linting. |
@marbar3778 does that just raise warnings? Could it fix them too? |
raise warnings, we use https://github.com/igorshubovych/markdownlint-cli to fix them |
Summary
Leaving trailing an whitespace in a code causes useless diffs. It's also not good for a code style.
make lint
should fail if there are trailing whitespacesmake lint-fix
should remove trailing whitespacesProblem Definition
#8107 (review)
For Admin Use
The text was updated successfully, but these errors were encountered: