Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gentx command does not error on 0 Amount #8174

Closed
4 tasks
AdityaSripal opened this issue Dec 16, 2020 · 3 comments · Fixed by #8183
Closed
4 tasks

gentx command does not error on 0 Amount #8174

AdityaSripal opened this issue Dec 16, 2020 · 3 comments · Fixed by #8183

Comments

@AdityaSripal
Copy link
Member

AdityaSripal commented Dec 16, 2020

Summary of Bug

Creating a gentx with 0 amount passes, and does not error until subsequent collect-gentxs command

Version

v0.40.0-rc5

Steps to Reproduce

gaiad gentx moniker --chain-id $chain-id
gaiad collect-gentxs

cc: @colin-axner


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner
Copy link
Contributor

colin-axner commented Dec 16, 2020

This is because the amount flag has a default value (100000stake). I think it'd be better if amount became an argument since it is required

@alexanderbez
Copy link
Contributor

This is because the amount flag has a default value (100000stake). I think it'd be better if amount became an argument since it is required

ACK 👍

@alessio
Copy link
Contributor

alessio commented Dec 17, 2020

This is because the amount flag has a default value (100000stake). I think it'd be better if amount became an argument since it is required

I very much agree with this. It is more correct and affects UX positively 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants