Paginate supply and balances methods

[sahith-narahari]

Summary

Ref: #8517
To have a better support for multiple tokens, we need to paginate GetTotalSupply and GetAllBalances which is being used across multiple modules

• Paginate supply queries #8798 Paginate GetTotalSupply
• Paginate GetAllBalances

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[amaury1093]

There's an item "Paginate GetAllBalances", but afaict it's already implemented. Can you confirm @sahith-narahari ?

[sahith-narahari]

There's an item "Paginate GetAllBalances", but afaict it's already implemented. Can you confirm @sahith-narahari ?

The question is do we want to paginate GetAllBalances similar to how we did supply?

It's used across various modules and maybe we should imo.

cosmos-sdk/x/bank/keeper/view.go

Line 61 in ef9968d

func (k BaseViewKeeper) GetAllBalances(ctx sdk.Context, addr sdk.AccAddress) sdk.Coins {

[amaury1093]

The question is do we want to paginate GetAllBalances similar to how we did supply?

I'm not sure I understand. Both RPC methods take a PaginationRequest param.

[sahith-narahari]

I'm referring to the keeper methods, ref: #8517 (comment)

[sahith-narahari]

I don't see much difference in using it without pagination though

[amaury1093]

OK, the gRPC handler correctly handles pagination. Only the keeper method doesn't. I'm fine with it as-is, you're probably right @sahith-narahari the "huge denom list" problem should be smaller on individual balances.

Unless if you want/started work on this, then feel free to continue!

[sahith-narahari]

I didn't start yet and agree with you. I propose to leave it as-is and get back to it if we see any problem in the future