Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean secp256k1 custom no-cgo code #8766

Closed
4 tasks
robert-zaremba opened this issue Mar 3, 2021 · 1 comment
Closed
4 tasks

Clean secp256k1 custom no-cgo code #8766

robert-zaremba opened this issue Mar 3, 2021 · 1 comment
Labels
C:Crypto
Milestone
Feature Backlog

Comments

@robert-zaremba
Copy link
Collaborator

robert-zaremba commented Mar 3, 2021 •
edited
Loading

Summary

The secp256k1 package contains a custom, pure go code. We should leverage the stdlib and crypto/keys/internal/ecdsa instead.

Ref;

Proposal

Remove custom pure go code from secp256k1/internal and use as described above.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba mentioned this issue Mar 3, 2021
Merged
9 tasks
@tac0turtle
Copy link
Member

duplicate of #7537

@robert-zaremba robert-zaremba mentioned this issue Mar 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:Crypto
Projects
None yet
Milestone
Feature Backlog
Development

No branches or pull requests
2 participants
@robert-zaremba @tac0turtle