simulation: use module accounts

[alexanderbez]

Currently, simulation discards module accounts from the global set of accounts which are used for simulation operations (i.e. txs/msgs). However, this is not ideal because it removes a certain area of simulation/test coverage.

Namely, at the very least, we should be using module accounts as a recipient of MsgSend and MsgMultiSend operations so we can cover these cases, i.e. these operations should fail.

If it can be attempted on the hub or any live network, it should be able to be attempted in simulations.

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[robert-zaremba]

Clarifying the scope of this task:

• Unlock the possibility to use module accounts in messages in simulation tests. Currently this is not allowed.
• identify and fix tests which could on the limitation above.
• add a simulation test which uses a module account for MsgSend

[aaronc]

@alexanderbez is what @robert-zaremba outlined accurate?

[robert-zaremba]

@aaronc - I discussed about this with @alexanderbez in a chat (the post above is almost a copy-past of a summary).

[cyberbono3]

I can start working on it

[cyberbono3]

1. Is this issue applicable to bank module only?
2. To make sure I understand the scope of this issue. My task is to implement 2 tests similar to TestSimulateMsgSend and TestSimulateMsgMultiSend. Instead of using these accounts i have to use random accounts accounts := simtypes.RandomAccounts(r, 3) so both tests have to fail. Does it sound right?

[anilcse]

1. Is this issue applicable to bank module only?
2. To make sure I understand the scope of this issue. My task is to implement 2 tests similar to TestSimulateMsgSend and TestSimulateMsgMultiSend. Instead of using these accounts i have to use random accounts accounts := simtypes.RandomAccounts(r, 3) so both tests have to fail. Does it sound right?

you have to use module accounts, not randomAccounts and yes, the tests should fail when using module accounts

[robert-zaremba]

I can start working on it

Thanks Andrei

[robert-zaremba]

PS: you should just add 1-2 tests which will use a module account.