Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/feegrant API audit #9028

Closed
3 tasks done
blushi opened this issue Mar 30, 2021 · 2 comments
Closed
3 tasks done

x/feegrant API audit #9028

blushi opened this issue Mar 30, 2021 · 2 comments

Comments

@blushi
Copy link
Contributor

blushi commented Mar 30, 2021

ref: #8983

  • Are Msg and Query methods and types well-named and organized?
  • Is everything well documented (inline godoc as well as /spec/ folder in module directory)
  • Check the proto definition - make sure everything is in accordance to ADR-29
@aleem1314
Copy link
Contributor

aleem1314 commented Apr 2, 2021

  • proto definitions:

  • specs & godocs

  • Msg & Query methods and types properly named

    • Msg & Query methods are properly named and well organized.
    • Few methods missing godoc in Msg & Query server.
    • QueryServer in keeper/grpc_query.go is not covered by unit tests.
    • Messages in types/msgs.go are not covered by unit tests.

@blushi blushi added this to the v0.43 milestone Apr 14, 2021
@blushi blushi added the backlog label Apr 14, 2021
@blushi
Copy link
Contributor Author

blushi commented Apr 16, 2021

Same as in x/authz, we should simplify msg and types naming.

@blushi blushi closed this as completed Apr 20, 2021
@aaronc aaronc removed the in-review label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants