Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto-swagger-gen script requires node module in docker container #9039

Closed
4 tasks
technicallyty opened this issue Mar 31, 2021 · 1 comment
Closed
4 tasks

Comments

@technicallyty
Copy link
Contributor

Summary of Bug

I updated the proto-swagger-gen call in the makefile to make use of the docker container:

$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace tendermintdev/sdk-proto-gen:v0.1 sh ./scripts/protoc-swagger-gen.sh

The underlying shell script calls a node module, swagger-combine. Currently, the docker image does not contain this node module.

Version

commit hash: 410d8ed (latest master)

Steps to Reproduce

run make proto-swagger-gen as is.
you should see this error:
--swagger_out: could not find protoc plugin for name swagger

replace the script in the make file for proto-swagger-gen to:

$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace tendermintdev/sdk-proto-gen:v0.1 sh ./scripts/protoc-swagger-gen.sh

you should see error:

./scripts/protoc-swagger-gen.sh: line 24: swagger-combine: not found

cc: @marbar3778


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@technicallyty
Copy link
Contributor Author

closing in favor of #7933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant