Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module spec towards service oriented architecture #9352

Closed
4 of 6 tasks
robert-zaremba opened this issue May 18, 2021 · 2 comments
Closed
4 of 6 tasks

Update module spec towards service oriented architecture #9352

robert-zaremba opened this issue May 18, 2021 · 2 comments
Labels
C:x/authz spec T:Docs Changes and features related to documentation.

Comments

@robert-zaremba
Copy link
Collaborator

Summary

In past year we checked few approach for designing modules and transaction messages. ADR-31 introduced Protobuf Service oriented architecture. Recently we simplified service request messages and types and update the documentation.
Our module specs are still oriented towards messages rather then services. Core modules act as a template and a guideline for all other modules. Hence we should update the documentation of the core modules towards the architecture we are implementing.

Proposal

In authz module spec, we drafted how the the service oriented spec can look like and decided to roll it back and have a separate issue to update the SPEC-SPEC document together with a module spec to present a

  • Update the SPEC-SPEC
  • Update x/authz/spec files

Once done, we should create follow-up tasks to migrate other module specs.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added T:Docs Changes and features related to documentation. spec C:x/authz labels May 18, 2021
@robert-zaremba robert-zaremba added this to the v0.43 milestone May 18, 2021
@robert-zaremba robert-zaremba self-assigned this May 18, 2021
@robert-zaremba
Copy link
Collaborator Author

Plan:

  • Propose updated spec
  • make a post
  • communicate

@github-actions github-actions bot added the stale label Aug 15, 2021
@aaronc aaronc modified the milestones: v0.43, v0.43.x Aug 19, 2021
@robert-zaremba robert-zaremba modified the milestones: v0.44.x, v0.45 Sep 29, 2021
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK May 12, 2022
@tac0turtle tac0turtle removed this from the v0.46 milestone May 27, 2022
@tac0turtle tac0turtle removed the R:0.46 label May 27, 2022
@tac0turtle tac0turtle moved this to ❌ Blocked in Cosmos-SDK Nov 16, 2023
@tac0turtle tac0turtle moved this from ❌ Blocked to ☃️ Icebox in Cosmos-SDK Mar 13, 2024
@julienrbrt
Copy link
Member

julienrbrt commented Oct 7, 2024

spec-spec has been simplified to not require that (https://github.com/cosmos/cosmos-sdk/blob/main/docs/spec/SPEC_MODULE.md)
we've simplified the docs of other modules.

the way to build module is to use core, which will be reflected in: #21429

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2024
@github-project-automation github-project-automation bot moved this from ☃️ Icebox to 🥳 Done in Cosmos-SDK Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/authz spec T:Docs Changes and features related to documentation.
Projects
Status: 🥳 Done
Development

No branches or pull requests

5 participants