Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaiad gentx refactoring - take #2 #2875

Closed
4 tasks
alessio opened this issue Nov 21, 2018 · 0 comments
Closed
4 tasks

gaiad gentx refactoring - take #2 #2875

alessio opened this issue Nov 21, 2018 · 0 comments
Assignees
@alessio

Comments

@alessio
Copy link
Contributor

alessio commented Nov 21, 2018 •
edited
Loading

Forked from #2874

Summary of Bug

Refactor gaiad gentx so that it does not call gaiacli tx sign anymore. It should use underlying signing functions instead.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio alessio changed the title Refactor gaiacli sign gaiacli sign refactoring Nov 21, 2018
@alessio alessio changed the title gaiacli sign refactoring gaiacli tx sign refactoring Nov 21, 2018
@alessio alessio changed the title gaiacli tx sign refactoring gaiad gentx refactoring - take #2 Nov 22, 2018
alessio pushed a commit that referenced this issue Nov 22, 2018
Don't call gaiacli tx sign. Use utils.SignStdTx() instead.
cc4a3da 
This is to avoid command redirection and reduce the use
of viper's global variables.

Closes: #2875
@alessio alessio mentioned this issue Nov 22, 2018
Merged
5 tasks
@alessio alessio self-assigned this Nov 22, 2018
alessio pushed a commit that referenced this issue Nov 23, 2018
Don't call gaiacli tx sign. Use utils.SignStdTx() instead.
72c9589 
This is to avoid command redirection and reduce the use
of viper's global variables.

Closes: #2875
cwgoes pushed a commit that referenced this issue Nov 26, 2018
@alessio @cwgoes
Merge PR #2881: Don't call gaiacli tx sign. Use utils.SignStdTx() ins…
4c36b0f 
…tead.

This is to avoid command redirection and reduce the use
of viper's global variables.

Closes: #2875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alessio