-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation Decoder Refactor #5664
Labels
T: Dev UX
UX for SDK developers (i.e. how to call our code)
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Comments
alexanderbez
added
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
T: Dev UX
UX for SDK developers (i.e. how to call our code)
labels
Feb 18, 2020
require.Equal(t, len(failedKVAs), 0, GetSimulationLog(skp.A.Name(), app.SimulationManager().StoreDecoders, app.Codec(), failedKVAs, failedKVBs)) This is the line that calls the actual decoder. Instead of passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T: Dev UX
UX for SDK developers (i.e. how to call our code)
Type: Code Hygiene
General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Summary
Each module defines a
DecodeStore
function that is used when import/export simulation errors. However, theDecodeStore
signature accepts a reference to a concrete Amino codec. Since the state is now serialized via Protobuf, we need to use acodec.Marshaler
.For Admin Use
The text was updated successfully, but these errors were encountered: