Ethermint key generation (#78)

* WIP setting up Ethereum key CLI commands

* Functional key gen and showing Ethereum address

* Cleaned up changes

* WIP setting up Ethereum key CLI commands

* Functional key gen and showing Ethereum address

* Cleaned up changes

* Changed address to cosmos specific address

* Remove default bech32 prefixes and add basic add command test

* Changed Private key type to slice of bytes for compatibility and storability

* switch back to using cosmos crypto Keybase interfaces

* Changed key output to ethereum addressing instead of bitcoin and key generation to allow seeding from mnemonic and bip39 password

* Updated show command and added test

* Remove prefix requirement for showing keys and added existing keys commands to CLI temporarily

* Removed unnecessary duplicate code

* Readd prefixes for accounts temporarily

* Fix linting issue

* Remove TODO for setting PK to specific length of bytes (all functions use slice)

* Cleaned up descriptions to remove multi-sigs

Author: austinabell

app/test_utils.go

@@ -90,7 +90,7 @@ func newTestStdFee() auth.StdFee {
 // GenerateAddress generates an Ethereum address.
 func newTestAddrKey() (sdk.AccAddress, tmcrypto.PrivKey) {
 	privkey, _ := crypto.GenerateKey()
-	addr := ethcrypto.PubkeyToAddress(privkey.PublicKey)
+	addr := ethcrypto.PubkeyToAddress(privkey.ToECDSA().PublicKey)
 
 	return sdk.AccAddress(addr.Bytes()), privkey
 }

cmd/emintcli/main.go

@@ -1,15 +1,17 @@
 package main
 
 import (
-	"github.com/cosmos/ethermint/rpc"
-	"github.com/tendermint/go-amino"
 	"os"
 	"path"
 
-	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/client/keys"
+	"github.com/cosmos/ethermint/rpc"
+	"github.com/tendermint/go-amino"
+
+	"github.com/cosmos/cosmos-sdk/client"
 	sdkrpc "github.com/cosmos/cosmos-sdk/client/rpc"
 	sdk "github.com/cosmos/cosmos-sdk/types"
+	emintkeys "github.com/cosmos/ethermint/keys"
 
 	emintapp "github.com/cosmos/ethermint/app"
 	"github.com/spf13/cobra"
@@ -24,6 +26,7 @@ func main() {
 
 	// Read in the configuration file for the sdk
 	config := sdk.GetConfig()
+	// TODO: Remove or change prefix if usable to generate Ethereum address
 	config.SetBech32PrefixForAccount(sdk.Bech32PrefixAccAddr, sdk.Bech32PrefixAccPub)
 	config.SetBech32PrefixForValidator(sdk.Bech32PrefixValAddr, sdk.Bech32PrefixValPub)
 	config.SetBech32PrefixForConsensusNode(sdk.Bech32PrefixConsAddr, sdk.Bech32PrefixConsPub)
@@ -49,7 +52,9 @@ func main() {
 		// TODO: Set up rest routes (if included, different from web3 api)
 		rpc.Web3RpcCmd(cdc),
 		client.LineBreak,
+		// TODO: Remove these commands once ethermint keys and genesis set up
 		keys.Commands(),
+		emintkeys.Commands(),
 		client.LineBreak,
 	)
 

cmd/emintd/main.go

@@ -28,6 +28,7 @@ func main() {
 	cdc := emintapp.MakeCodec()
 
 	config := sdk.GetConfig()
+	// TODO: Remove or change prefix if usable to generate Ethereum address
 	config.SetBech32PrefixForAccount(sdk.Bech32PrefixAccAddr, sdk.Bech32PrefixAccPub)
 	config.SetBech32PrefixForValidator(sdk.Bech32PrefixValAddr, sdk.Bech32PrefixValPub)
 	config.SetBech32PrefixForConsensusNode(sdk.Bech32PrefixConsAddr, sdk.Bech32PrefixConsPub)

crypto/codec.go

@@ -1,6 +1,8 @@
 package crypto
 
-import "github.com/cosmos/cosmos-sdk/codec"
+import (
+	"github.com/cosmos/cosmos-sdk/codec"
+)
 
 var cryptoCodec = codec.New()
 

crypto/keys/codec.go

@@ -0,0 +1,25 @@
+package keys
+
+import (
+	cryptoAmino "github.com/tendermint/tendermint/crypto/encoding/amino"
+
+	"github.com/cosmos/cosmos-sdk/codec"
+	"github.com/cosmos/cosmos-sdk/crypto/keys/hd"
+	emintCrypto "github.com/cosmos/ethermint/crypto"
+	cosmosKeys "github.com/cosmos/cosmos-sdk/crypto/keys"
+)
+
+var cdc *codec.Codec
+
+func init() {
+	cdc = codec.New()
+	cryptoAmino.RegisterAmino(cdc)
+	cdc.RegisterInterface((*cosmosKeys.Info)(nil), nil)
+	emintCrypto.RegisterCodec(cdc)
+	cdc.RegisterConcrete(hd.BIP44Params{}, "crypto/keys/hd/BIP44Params", nil)
+	cdc.RegisterConcrete(localInfo{}, "crypto/keys/localInfo", nil)
+	cdc.RegisterConcrete(ledgerInfo{}, "crypto/keys/ledgerInfo", nil)
+	cdc.RegisterConcrete(offlineInfo{}, "crypto/keys/offlineInfo", nil)
+	// cdc.RegisterConcrete(multiInfo{}, "crypto/keys/multiInfo", nil)
+	cdc.Seal()
+}