Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing address in signing_infos of rest api #1344 #1734

Closed
4 tasks
Tracked by #2790
okwme opened this issue Apr 11, 2022 · 6 comments · Fixed by #2886
Closed
4 tasks
Tracked by #2790

Missing address in signing_infos of rest api #1344 #1734

okwme opened this issue Apr 11, 2022 · 6 comments · Fixed by #2886
Assignees
Labels
good first issue Good for newcomers S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability type: bug Issues that need priority attention -- something isn't working type: tech-debt Slows down development in the long run

Comments

@okwme
Copy link
Contributor

okwme commented Apr 11, 2022

Reposting issue by @liangping originally posted #1344

Summary of Bug

visit: https://cosmos.api.ping.pub/cosmos/slashing/v1beta1/signing_infos

  "info": [
    {
      "address": "",   ADDRESS SHOULD NOT BE EMPTY.
      "start_height": "0",
      "index_offset": "13174927",
      "jailed_until": "1970-01-01T00:00:00Z",
      "tombstoned": false,
      "missed_blocks_counter": "0"
    },
    {
      "address": "", ADDRESS SHOULD NOT BE EMPTY.
      "start_height": "0",
      "index_offset": "13174927",
      "jailed_until": "1970-01-01T00:00:00Z",
      "tombstoned": false,
      "missed_blocks_counter": "40"
    },
    {
      "address": "cosmosvalcons1qrxwan7srvknxwsm264l0nlc56uw6fd3mq0s7v",
      "start_height": "4211581",
      "index_offset": "3958948",
      "jailed_until": "1970-01-01T00:00:00Z",
      "tombstoned": false,
      "missed_blocks_counter": "26"
    },

Version

"cosmos_sdk_version":"v0.44.3"

Steps to Reproduce

Not see this issue on other blockchains: like Osmosis


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alexanderbez
Copy link
Contributor

Super weird. Could be something trivial. Will take a look...

@alexanderbez
Copy link
Contributor

I'm stumped here as to how we have records w/o addresses as there are numerous safe guards around addresses.

However, if you notice all the records with an empty address have a start_height of 0. This indicates perhaps some invalid upgrade code that existed some while ago or maybe they were pruned somehow :-/

Regardless, I wouldn't worry to much about this. Maybe in the next Gaia release, we delete all records with an empty address.

@tac0turtle
Copy link
Member

moving this to gaia as its related to the hub

@tac0turtle tac0turtle transferred this issue from cosmos/cosmos-sdk Sep 7, 2022
@okwme okwme removed their assignment Dec 22, 2022
@mpoke mpoke added the type: tech-debt Slows down development in the long run label Jan 27, 2023
@mpoke mpoke added this to the Gaia v10.0.0 milestone Jan 27, 2023
@mpoke mpoke removed this from the Gaia v10.0.0 milestone Mar 6, 2023
@mpoke mpoke added the type: bug Issues that need priority attention -- something isn't working label Mar 9, 2023
@mpoke mpoke added this to the Next patch release milestone Mar 9, 2023
@mpoke mpoke assigned glnro and unassigned shaspitz Mar 22, 2023
@mpoke mpoke mentioned this issue Apr 14, 2023
@mpoke mpoke removed this from the Next patch release milestone Apr 14, 2023
@mpoke mpoke unassigned glnro May 11, 2023
@freak12techno
Copy link
Contributor

Is this issue being worked at right now?
I am facing this issue as well: my fullnode returns some signing infos with empty address, so I cannot map it to its validator. This is important for me as I am writing a tool to track validators' missed blocks and now instead of 1 query I need to do 500+ queries to get how many missed blocks are there for a validator.
To add context: this endpoint https://api.cosmos.quokkastake.io/cosmos/slashing/v1beta1/signing_infos on my fullnode returns some validators with empty address (for example, there's no entry for Cosmostation validator, valoper=cosmosvaloper1clpqr4nrk4khgkxj78fcwwh6dl3uw4epsluffn, valcons=cosmosvalcons1px0zkz2cxvc6lh34uhafveea9jnaagckmrlsye), however if I do a request to the signing info of this valcons address directly (https://api.cosmos.quokkastake.io/cosmos/slashing/v1beta1/signing_infos/cosmosvalcons1px0zkz2cxvc6lh34uhafveea9jnaagckmrlsye), it returns the data, however without address.

@mpoke mpoke added the good first issue Good for newcomers label May 26, 2023
@mpoke mpoke added the S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability label Sep 12, 2023
@livthomas
Copy link

I've also run into this bug. It doesn't look like those are old records because missed_blocks_counter is often not empty.

See the issues I opened in other repos:

It can be reproduced via both (g)RPC and REST API. And it only affects Cosmos Hub as I haven't been able to reproduce it on any other chain.

@sainoe
Copy link
Contributor

sainoe commented Dec 1, 2023

Thanks again @livthomas for providing these insightful details about the issue!

Based on our investigation, we have identified that the issue spans a considerable number of the signing info records (168/444 to this date). Although pinpointing the exact root cause proves challenging, it's clear that these incorrect records are associated with active validators and require rectification.

We plan to address this issue during the Gaia v15 upgrade migration, by filling in the missing address in the signing info records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers S: ImprovingThings Improving things: Customer requests, performance improvements, reliability and usability type: bug Issues that need priority attention -- something isn't working type: tech-debt Slows down development in the long run
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

10 participants