Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove third_party/proto, and use buf registry for proto deps #2215

Closed
5 tasks
Tracked by #2413
yaruwangway opened this issue Feb 16, 2023 · 1 comment
Closed
5 tasks
Tracked by #2413

remove third_party/proto, and use buf registry for proto deps #2215

yaruwangway opened this issue Feb 16, 2023 · 1 comment

Comments

@yaruwangway
Copy link
Contributor

yaruwangway commented Feb 16, 2023

Summary

Presently, the proto deps are copied to gaia/third_party/proto. This causes extra works of copying when the dependencies version updates.

From sdk 0.46 onwards, we can use refer to buf registry for proto deps
This was done before when we were trying to use 0.46 (finally reverted to sdk 0.45)

Problem Definition

Concerns

Copy pasting proto files are tedious and error-prone.

Proposal

remove third_party/proto and use buf registry.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@yaruwangway yaruwangway added this to the Gaia v10.0.0 milestone Feb 16, 2023
@yaruwangway yaruwangway changed the title Gaia v10: remove third_party/proto, and use buf registry to refer to proto deps Gaia v10: remove third_party/proto, and use buf registry for proto deps Feb 16, 2023
@yaruwangway yaruwangway modified the milestones: Gaia v10.0.0, Bump SDK to 0.47 Feb 23, 2023
@mpoke mpoke removed this from the Bump SDK to 0.47 milestone Mar 5, 2023
@mpoke mpoke changed the title Gaia v10: remove third_party/proto, and use buf registry for proto deps remove third_party/proto, and use buf registry for proto deps Mar 6, 2023
@mpoke
Copy link
Contributor

mpoke commented Sep 14, 2023

Closing as this work is tracked by #2540

@mpoke mpoke closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants