Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packet-forward-middleware not working as expected #2669

Closed
5 tasks
devon-chain opened this issue Jul 27, 2023 · 2 comments · Fixed by #2677
Closed
5 tasks

packet-forward-middleware not working as expected #2669

devon-chain opened this issue Jul 27, 2023 · 2 comments · Fixed by #2677
Assignees
Labels
type: bug Issues that need priority attention -- something isn't working

Comments

@devon-chain
Copy link

Summary of Bug

When I forward ibc transfer tx to osmosis via cosmoshub, if the amount is greater than the maximum value of int64, the estimated will fail, this problem exists in both mainnet and testnet

Before the v4.0.6 of packet-forward-middleware, if ibc transfer amount was greater than the maximum value of int64, the conversion would overflow, causing the code to panic, and tx would fail

Related issues:
gaia #2553
packet-forward-middleware #78

Version

gaia: v10.0.2(Latest)
gaia: v11.0.0(Pre-release)

Steps to Reproduce

Send ibc transfer tx to chainA(Any chain with which cosmoshub has created an ibc channel), receiver is cosmoshub, amount must be greater than maximum value of int64, and fill tx memo with forward data (for example, forward to osmosis/evmos/kava)


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@devon-chain devon-chain added type: bug Issues that need priority attention -- something isn't working status: waiting-triage This issue/PR has not yet been triaged by the team. labels Jul 27, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Jul 27, 2023
@jtieri
Copy link
Member

jtieri commented Jul 27, 2023

This issue should have been addressed in v4.0.6 of the packet forward middleware, it looks like Gaia is still using v4.0.5. I suspect that an upgrade to the patched version is all that is necessary to rectify the issue.

@mpoke mpoke mentioned this issue Jul 28, 2023
8 tasks
@mpoke mpoke removed the status: waiting-triage This issue/PR has not yet been triaged by the team. label Jul 28, 2023
@mpoke mpoke moved this from 🩹 Triage to 👀 In review in Cosmos Hub Jul 28, 2023
@mpoke mpoke self-assigned this Jul 28, 2023
@mpoke
Copy link
Contributor

mpoke commented Jul 28, 2023

@devon-chain Thanks for opening the issue. I opened a PR to bump the PFM version #2677. Thanks @jtieri.

@mpoke mpoke moved this from 👀 In review to 🛑 Blocked in Cosmos Hub Aug 3, 2023
@mpoke mpoke moved this from 🛑 Blocked to 👀 In review in Cosmos Hub Aug 8, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Issues that need priority attention -- something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants