Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Tendermint dependency from v0.19.x #682

Closed
julienrbrt opened this issue Feb 17, 2023 · 2 comments
Closed

Remove Tendermint dependency from v0.19.x #682

julienrbrt opened this issue Feb 17, 2023 · 2 comments

Comments

@julienrbrt
Copy link
Member

julienrbrt commented Feb 17, 2023 •
edited
Loading

For migrating Cosmos SDK v0.47.x to CometBFT, we need to remove tendermint/tendermint dependency from the SDK dependency graph. ref cosmos/cosmos-sdk#15060 (comment).

We should keep tm-db (and not migrate at the same time to cosmos-db / cometbft-db), as we need it for v0.45 and v0.46 (and v0.47).

This has been done on main 3da7063, would it be possible to do the same for the v0.19.x line?

cc @tac0turtle @cool-develope
@julienrbrt julienrbrt mentioned this issue Feb 17, 2023
Merged
25 tasks
@tac0turtle
Copy link
Member

this isnt possible for 0.19, we will need to QA IAVL on top of the 0.47 release. i guess we dont have a choice........

@julienrbrt julienrbrt mentioned this issue Feb 18, 2023
Merged
@julienrbrt
Copy link
Member Author

Closing this then, as discussed (on Slack), I have a PR reverting the migration to Cosmos-DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tac0turtle @julienrbrt