Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit 0148576

Browse files
authoredJul 21, 2021
rename ibc-account -> interchain-accounts (#280)
* rename ibc-account -> interchain-accounts * fix codeowner file
1 parent c27653a commit 0148576

29 files changed

+40
-40
lines changed
 

‎.github/CODEOWNERS

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@
44

55
# CODEOWNERS for interchain-accounts module
66

7-
*/modules/apps/ibc-account @seantking @colin-axner @AdityaSripal
7+
*/modules/apps/27-interchain-accounts @seantking @colin-axner @AdityaSripal

‎modules/apps/ibc-account/client/cli/query.go ‎modules/apps/27-interchain-accounts/client/cli/query.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ import (
77
"github.com/cosmos/cosmos-sdk/client/flags"
88
"github.com/spf13/cobra"
99

10-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/types"
10+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/types"
1111
)
1212

1313
func GetQueryCmd() *cobra.Command {
1414
cmd := &cobra.Command{
15-
Use: types.ModuleName,
16-
Short: "Querying commands for the ibc account module",
15+
Use: "interchain-accounts",
16+
Short: "Querying commands for the interchain accounts module",
1717
DisableFlagParsing: true,
1818
SuggestionsMinimumDistance: 2,
1919
RunE: client.ValidateCmd,

‎modules/apps/ibc-account/genesis.go ‎modules/apps/27-interchain-accounts/genesis.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import (
44
"fmt"
55

66
sdk "github.com/cosmos/cosmos-sdk/types"
7-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/keeper"
8-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/types"
7+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/keeper"
8+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/types"
99
)
1010

1111
func InitGenesis(ctx sdk.Context, keeper keeper.Keeper, state types.GenesisState) {

‎modules/apps/ibc-account/keeper/account.go ‎modules/apps/27-interchain-accounts/keeper/account.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
77
channeltypes "github.com/cosmos/ibc-go/modules/core/04-channel/types"
88
host "github.com/cosmos/ibc-go/modules/core/24-host"
9-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/types"
9+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/types"
1010
"github.com/tendermint/tendermint/crypto/tmhash"
1111
)
1212

‎modules/apps/ibc-account/keeper/grpc_query.go ‎modules/apps/27-interchain-accounts/keeper/grpc_query.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
"google.golang.org/grpc/codes"
99
"google.golang.org/grpc/status"
1010

11-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/types"
11+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/types"
1212
)
1313

1414
var _ types.QueryServer = Keeper{}

‎modules/apps/ibc-account/keeper/keeper.go ‎modules/apps/27-interchain-accounts/keeper/keeper.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import (
1414
host "github.com/cosmos/ibc-go/modules/core/24-host"
1515
"github.com/tendermint/tendermint/libs/log"
1616

17-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/types"
17+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/types"
1818
)
1919

2020
// Keeper defines the IBC transfer keeper
@@ -34,7 +34,7 @@ type Keeper struct {
3434
memKey sdk.StoreKey
3535
}
3636

37-
// NewKeeper creates a new IBC account Keeper instance
37+
// NewKeeper creates a new interchain account Keeper instance
3838
func NewKeeper(
3939
memKey sdk.StoreKey,
4040
cdc codec.BinaryCodec, key sdk.StoreKey,
@@ -112,7 +112,7 @@ func (k Keeper) BindPort(ctx sdk.Context, portID string) error {
112112
return k.ClaimCapability(ctx, cap, host.PortPath(portID))
113113
}
114114

115-
// GetPort returns the portID for the ibc account module. Used in ExportGenesis
115+
// GetPort returns the portID for the interchain accounts module. Used in ExportGenesis
116116
func (k Keeper) GetPort(ctx sdk.Context) string {
117117
store := ctx.KVStore(k.storeKey)
118118
return string(store.Get([]byte(types.PortKey)))

‎modules/apps/ibc-account/keeper/relay.go ‎modules/apps/27-interchain-accounts/keeper/relay.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import (
88
clienttypes "github.com/cosmos/ibc-go/modules/core/02-client/types"
99
channeltypes "github.com/cosmos/ibc-go/modules/core/04-channel/types"
1010
host "github.com/cosmos/ibc-go/modules/core/24-host"
11-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/types"
11+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/types"
1212
"github.com/tendermint/tendermint/crypto/tmhash"
1313
)
1414

‎modules/apps/ibc-account/module.go ‎modules/apps/27-interchain-accounts/module.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ import (
1717
"github.com/grpc-ecosystem/grpc-gateway/runtime"
1818
abci "github.com/tendermint/tendermint/abci/types"
1919

20-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/client/cli"
21-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/keeper"
22-
"github.com/cosmos/ibc-go/modules/apps/ibc-account/types"
20+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/client/cli"
21+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/keeper"
22+
"github.com/cosmos/ibc-go/modules/apps/27-interchain-accounts/types"
2323
channeltypes "github.com/cosmos/ibc-go/modules/core/04-channel/types"
2424
porttypes "github.com/cosmos/ibc-go/modules/core/05-port/types"
2525
ibcexported "github.com/cosmos/ibc-go/modules/core/exported"
@@ -68,7 +68,7 @@ func (AppModuleBasic) RegisterInterfaces(registry codectypes.InterfaceRegistry)
6868
types.RegisterInterfaces(registry)
6969
}
7070

71-
// RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the ibc-account module.
71+
// RegisterGRPCGatewayRoutes registers the gRPC Gateway routes for the interchain accounts module.
7272
func (AppModuleBasic) RegisterGRPCGatewayRoutes(clientCtx client.Context, mux *runtime.ServeMux) {
7373
}
7474

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<!--
2+
order: 0
3+
title: "Overview"
4+
parent:
5+
title: "Interchain Accounts"
6+
-->
7+
8+
# Interchain Account
9+
10+
## Abstract
11+
12+
This document specifies the ICS 27 Interchain Account module for the Cosmos SDK.
13+
14+
The Interchain Accounts module manages the creation of Interchain Accounts. This module is built based on the [ICS27 specification](https://github.com/cosmos/ibc/tree/master/spec/app/ics-027-interchain-accounts). Interchain Accounts allow a remote, IBC-connected **controller blockchain** to request an arbitrary transaction to be executed on the **host blockchain**(the chain which hosts the IBC account) via the interchain account. It should be noted that an interchain account has similar properties to a user account, and are bound to the same restrictions (unbonding periods, redelegation rules, etc).
15+
16+
The current implementation allows the same interchain account module on the destination chain to run any of the domiciling blockchain's native transactions that a user account is able to request(i.e. same module can handle 'send', 'stake', 'vote', etc), but the controlling chain/source chain must implement its own logic for controlling the interchain account.
17+
18+
## Contents
19+
1. **[Types](03_types.md)**
20+
2. **[Keeper](04_keeper.md)**
21+
3. **[Packets](05_packets.md)**

‎modules/apps/ibc-account/types/account.go ‎modules/apps/27-interchain-accounts/types/account.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ func NewIBCAccount(ba *authtypes.BaseAccount, accountOwner string) *IBCAccount {
3333

3434
// SetPubKey - Implements AccountI
3535
func (IBCAccount) SetPubKey(pubKey crypto.PubKey) error {
36-
return fmt.Errorf("not supported for ibc accounts")
36+
return fmt.Errorf("not supported for interchain accounts")
3737
}
3838

3939
// SetSequence - Implements AccountI
4040
func (IBCAccount) SetSequence(seq uint64) error {
41-
return fmt.Errorf("not supported for ibc accounts")
41+
return fmt.Errorf("not supported for interchain accounts")
4242
}
4343

4444
func (ia IBCAccount) Validate() error {

‎modules/apps/ibc-account/types/codec.go ‎modules/apps/27-interchain-accounts/types/codec.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
// provided LegacyAmino codec. These types are used for Amino JSON serialization
1111
func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) {
1212
cdc.RegisterInterface((*IBCAccountI)(nil), nil)
13-
cdc.RegisterConcrete(&IBCAccount{}, "ibc-account/IBCAccount", nil)
13+
cdc.RegisterConcrete(&IBCAccount{}, "27-interchain-accounts/IBCAccount", nil)
1414
}
1515

1616
// RegisterInterface associates protoName with AccountI interface

‎modules/apps/ibc-account/spec/README.md

-21
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.