Skip to content

Commit 2b955f8

Browse files
authored
marshaler -> codec (#3970)
1 parent 8824b2d commit 2b955f8

File tree

8 files changed

+15
-15
lines changed

8 files changed

+15
-15
lines changed

modules/apps/27-interchain-accounts/controller/types/msgs_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ func TestMsgSendTxValidateBasic(t *testing.T) {
143143
Amount: ibctesting.TestCoins,
144144
}
145145

146-
data, err := icatypes.SerializeCosmosTx(simapp.MakeTestEncodingConfig().Marshaler, []proto.Message{msgBankSend})
146+
data, err := icatypes.SerializeCosmosTx(simapp.MakeTestEncodingConfig().Codec, []proto.Message{msgBankSend})
147147
require.NoError(t, err)
148148

149149
packetData := icatypes.InterchainAccountPacketData{
@@ -179,7 +179,7 @@ func TestMsgSendTxGetSigners(t *testing.T) {
179179
Amount: ibctesting.TestCoins,
180180
}
181181

182-
data, err := icatypes.SerializeCosmosTx(simapp.MakeTestEncodingConfig().Marshaler, []proto.Message{msgBankSend})
182+
data, err := icatypes.SerializeCosmosTx(simapp.MakeTestEncodingConfig().Codec, []proto.Message{msgBankSend})
183183
require.NoError(t, err)
184184

185185
packetData := icatypes.InterchainAccountPacketData{

modules/apps/27-interchain-accounts/types/codec_test.go

+5-5
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,10 @@ func (suite *TypesTestSuite) TestSerializeAndDeserializeCosmosTx() {
110110
tc := tc
111111

112112
suite.Run(tc.name, func() {
113-
bz, err := types.SerializeCosmosTx(simapp.MakeTestEncodingConfig().Marshaler, tc.msgs)
113+
bz, err := types.SerializeCosmosTx(simapp.MakeTestEncodingConfig().Codec, tc.msgs)
114114
suite.Require().NoError(err, tc.name)
115115

116-
msgs, err := types.DeserializeCosmosTx(simapp.MakeTestEncodingConfig().Marshaler, bz)
116+
msgs, err := types.DeserializeCosmosTx(simapp.MakeTestEncodingConfig().Codec, bz)
117117
if tc.expPass {
118118
suite.Require().NoError(err, tc.name)
119119
} else {
@@ -127,16 +127,16 @@ func (suite *TypesTestSuite) TestSerializeAndDeserializeCosmosTx() {
127127
}
128128

129129
// test serializing non sdk.Msg type
130-
bz, err := types.SerializeCosmosTx(simapp.MakeTestEncodingConfig().Marshaler, []proto.Message{&banktypes.MsgSendResponse{}})
130+
bz, err := types.SerializeCosmosTx(simapp.MakeTestEncodingConfig().Codec, []proto.Message{&banktypes.MsgSendResponse{}})
131131
suite.Require().NoError(err)
132132
suite.Require().NotEmpty(bz)
133133

134134
// test deserializing unknown bytes
135-
_, err = types.DeserializeCosmosTx(simapp.MakeTestEncodingConfig().Marshaler, bz)
135+
_, err = types.DeserializeCosmosTx(simapp.MakeTestEncodingConfig().Codec, bz)
136136
suite.Require().Error(err) // unregistered type
137137

138138
// test deserializing unknown bytes
139-
msgs, err := types.DeserializeCosmosTx(simapp.MakeTestEncodingConfig().Marshaler, []byte("invalid"))
139+
msgs, err := types.DeserializeCosmosTx(simapp.MakeTestEncodingConfig().Codec, []byte("invalid"))
140140
suite.Require().Error(err)
141141
suite.Require().Empty(msgs)
142142
}

testing/app.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ func SetupTestingApp() (TestingApp, map[string]json.RawMessage) {
5757
db := dbm.NewMemDB()
5858
encCdc := simapp.MakeTestEncodingConfig()
5959
app := simapp.NewSimApp(log.NewNopLogger(), db, nil, true, map[int64]bool{}, simapp.DefaultNodeHome, 5, encCdc, simtestutil.EmptyAppOptions{})
60-
return app, simapp.NewDefaultGenesisState(encCdc.Marshaler)
60+
return app, simapp.NewDefaultGenesisState(encCdc.Codec)
6161
}
6262

6363
// SetupWithGenesisValSet initializes a new SimApp with a validator set and genesis accounts

testing/simapp/app.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ func NewSimApp(
277277
homePath string, invCheckPeriod uint, encodingConfig simappparams.EncodingConfig,
278278
appOpts servertypes.AppOptions, baseAppOptions ...func(*baseapp.BaseApp),
279279
) *SimApp {
280-
appCodec := encodingConfig.Marshaler
280+
appCodec := encodingConfig.Codec
281281
legacyAmino := encodingConfig.Amino
282282
interfaceRegistry := encodingConfig.InterfaceRegistry
283283

testing/simapp/params/encoding.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import (
1010
// This is provided for compatibility between protobuf and amino implementations.
1111
type EncodingConfig struct {
1212
InterfaceRegistry types.InterfaceRegistry
13-
Marshaler codec.Codec
13+
Codec codec.Codec
1414
TxConfig client.TxConfig
1515
Amino *codec.LegacyAmino
1616
}

testing/simapp/params/proto.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ import (
1616
func MakeTestEncodingConfig() EncodingConfig {
1717
cdc := codec.NewLegacyAmino()
1818
interfaceRegistry := types.NewInterfaceRegistry()
19-
marshaler := codec.NewProtoCodec(interfaceRegistry)
19+
codec := codec.NewProtoCodec(interfaceRegistry)
2020

2121
return EncodingConfig{
2222
InterfaceRegistry: interfaceRegistry,
23-
Marshaler: marshaler,
24-
TxConfig: tx.NewTxConfig(marshaler, tx.DefaultSignModes),
23+
Codec: codec,
24+
TxConfig: tx.NewTxConfig(codec, tx.DefaultSignModes),
2525
Amino: cdc,
2626
}
2727
}

testing/simapp/simd/cmd/root.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import (
4343
func NewRootCmd() (*cobra.Command, params.EncodingConfig) {
4444
encodingConfig := simapp.MakeTestEncodingConfig()
4545
initClientCtx := client.Context{}.
46-
WithCodec(encodingConfig.Marshaler).
46+
WithCodec(encodingConfig.Codec).
4747
WithInterfaceRegistry(encodingConfig.InterfaceRegistry).
4848
WithTxConfig(encodingConfig.TxConfig).
4949
WithLegacyAmino(encodingConfig.Amino).

testing/simapp/test_helpers.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ func setup(withGenesis bool, invCheckPeriod uint) (*SimApp, GenesisState) {
5555
encCdc := MakeTestEncodingConfig()
5656
app := NewSimApp(log.NewNopLogger(), db, nil, true, map[int64]bool{}, DefaultNodeHome, invCheckPeriod, encCdc, simtestutil.EmptyAppOptions{})
5757
if withGenesis {
58-
return app, NewDefaultGenesisState(encCdc.Marshaler)
58+
return app, NewDefaultGenesisState(encCdc.Codec)
5959
}
6060
return app, GenesisState{}
6161
}

0 commit comments

Comments
 (0)