Skip to content

Commit 79d55ff

Browse files
daeMOn63mergify-bot
authored and
mergify-bot
committed
docs: add missing args to NewKeeper in integration docs (#1038)
## Description This add some missing arguments to `ibckeeper.NewKeeper` and `ibctransferkeeper.NewKeeper` in integration docs --- Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why. - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work. - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md). - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing) - [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`) - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code). - [ ] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md` - [ ] Re-reviewed `Files changed` in the Github PR explorer - [ ] Review `Codecov Report` in the comment section below once CI passes (cherry picked from commit f71a505)
1 parent df58b8e commit 79d55ff

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

docs/ibc/integration.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -92,13 +92,13 @@ func NewApp(...args) *App {
9292

9393
// Create IBC Keeper
9494
app.IBCKeeper = ibckeeper.NewKeeper(
95-
appCodec, keys[ibchost.StoreKey], app.StakingKeeper, scopedIBCKeeper,
95+
appCodec, keys[ibchost.StoreKey], app.GetSubspace(ibchost.ModuleName), app.StakingKeeper, app.UpgradeKeeper, scopedIBCKeeper,
9696
)
9797

9898
// Create Transfer Keepers
9999
app.TransferKeeper = ibctransferkeeper.NewKeeper(
100-
appCodec, keys[ibctransfertypes.StoreKey],
101-
app.IBCKeeper.ChannelKeeper, &app.IBCKeeper.PortKeeper,
100+
appCodec, keys[ibctransfertypes.StoreKey], app.GetSubspace(ibctransfertypes.ModuleName),
101+
app.IBCKeeper.ChannelKeeper, app.IBCKeeper.ChannelKeeper, &app.IBCKeeper.PortKeeper,
102102
app.AccountKeeper, app.BankKeeper, scopedTransferKeeper,
103103
)
104104
transferModule := transfer.NewAppModule(app.TransferKeeper)

0 commit comments

Comments
 (0)