Skip to content

Commit d5e55b7

Browse files
nit(callbacks): removed unused testing func params (#4462)
Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
1 parent 01995a5 commit d5e55b7

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

modules/apps/callbacks/fee_transfer_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ func (s *CallbacksTestSuite) TestIncentivizedTransferTimeoutCallbacks() {
184184

185185
s.ExecutePayPacketFeeMsg(fee)
186186
preRelaySenderBalance := sdk.NewCoins(GetSimApp(s.chainA).BankKeeper.GetBalance(s.chainA.GetContext(), s.chainA.SenderAccount.GetAddress(), ibctesting.TestCoin.Denom))
187-
s.ExecuteTransferTimeout(tc.transferMemo, 1)
187+
s.ExecuteTransferTimeout(tc.transferMemo)
188188

189189
// after incentivizing the packets
190190
s.AssertHasExecutedExpectedCallbackWithFee(tc.expCallback, tc.expSuccess, true, preRelaySenderBalance, fee)

modules/apps/callbacks/ica_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ func (s *CallbacksTestSuite) TestICACallbacks() {
8181
s.Run(tc.name, func() {
8282
icaAddr := s.SetupICATest()
8383

84-
s.ExecuteICATx(icaAddr, tc.icaMemo, 1)
84+
s.ExecuteICATx(icaAddr, tc.icaMemo)
8585
s.AssertHasExecutedExpectedCallback(tc.expCallback, tc.expSuccess)
8686
})
8787
}
@@ -131,14 +131,14 @@ func (s *CallbacksTestSuite) TestICATimeoutCallbacks() {
131131
s.Run(tc.name, func() {
132132
icaAddr := s.SetupICATest()
133133

134-
s.ExecuteICATimeout(icaAddr, tc.icaMemo, 1)
134+
s.ExecuteICATimeout(icaAddr, tc.icaMemo)
135135
s.AssertHasExecutedExpectedCallback(tc.expCallback, tc.expSuccess)
136136
})
137137
}
138138
}
139139

140140
// ExecuteICATx executes a stakingtypes.MsgDelegate on chainB by sending a packet containing the msg to chainB
141-
func (s *CallbacksTestSuite) ExecuteICATx(icaAddress, memo string, seq uint64) {
141+
func (s *CallbacksTestSuite) ExecuteICATx(icaAddress, memo string) {
142142
timeoutTimestamp := uint64(s.chainA.GetContext().BlockTime().Add(time.Minute).UnixNano())
143143
icaOwner := s.chainA.SenderAccount.GetAddress().String()
144144
connectionID := s.path.EndpointA.ConnectionID
@@ -159,7 +159,7 @@ func (s *CallbacksTestSuite) ExecuteICATx(icaAddress, memo string, seq uint64) {
159159
}
160160

161161
// ExecuteICATx sends and times out an ICA tx
162-
func (s *CallbacksTestSuite) ExecuteICATimeout(icaAddress, memo string, seq uint64) {
162+
func (s *CallbacksTestSuite) ExecuteICATimeout(icaAddress, memo string) {
163163
relativeTimeout := uint64(1)
164164
icaOwner := s.chainA.SenderAccount.GetAddress().String()
165165
connectionID := s.path.EndpointA.ConnectionID

modules/apps/callbacks/transfer_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ func (s *CallbacksTestSuite) TestTransferTimeoutCallbacks() {
161161
for _, tc := range testCases {
162162
s.SetupTransferTest()
163163

164-
s.ExecuteTransferTimeout(tc.transferMemo, 1)
164+
s.ExecuteTransferTimeout(tc.transferMemo)
165165
s.AssertHasExecutedExpectedCallback(tc.expCallback, tc.expSuccess)
166166
}
167167
}
@@ -206,7 +206,7 @@ func (s *CallbacksTestSuite) ExecuteTransfer(memo string) {
206206

207207
// ExecuteTransferTimeout executes a transfer message on chainA for 100 denom.
208208
// This message is not relayed to chainB, and it times out on chainA.
209-
func (s *CallbacksTestSuite) ExecuteTransferTimeout(memo string, nextSeqRecv uint64) {
209+
func (s *CallbacksTestSuite) ExecuteTransferTimeout(memo string) {
210210
timeoutHeight := clienttypes.GetSelfHeight(s.chainB.GetContext())
211211
timeoutTimestamp := uint64(s.chainB.GetContext().BlockTime().UnixNano())
212212

0 commit comments

Comments
 (0)