Skip to content

Commit f46317e

Browse files
charleenfeimergify[bot]
authored andcommitted
fix: rm bech32 check from owner address on ICA controller msgs RegisterInterchainAccount and SendTx (#2601)
* rm validate basic owner address check (cherry picked from commit e8ff311)
1 parent 4b0b5af commit f46317e

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

modules/apps/27-interchain-accounts/controller/types/msgs.go

-8
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ func (msg MsgRegisterInterchainAccount) ValidateBasic() error {
3131
return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "owner address cannot be empty")
3232
}
3333

34-
if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil {
35-
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner)
36-
}
37-
3834
return nil
3935
}
4036

@@ -68,10 +64,6 @@ func (msg MsgSendTx) ValidateBasic() error {
6864
return sdkerrors.Wrap(sdkerrors.ErrInvalidAddress, "owner address cannot be empty")
6965
}
7066

71-
if _, err := sdk.AccAddressFromBech32(msg.Owner); err != nil {
72-
return sdkerrors.Wrapf(sdkerrors.ErrInvalidAddress, "failed to parse owner address: %s", msg.Owner)
73-
}
74-
7567
if err := msg.PacketData.ValidateBasic(); err != nil {
7668
return sdkerrors.Wrap(err, "invalid interchain account packet data")
7769
}

modules/apps/27-interchain-accounts/controller/types/msgs_test.go

-14
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,6 @@ func TestMsgRegisterInterchainAccountValidateBasic(t *testing.T) {
6161
},
6262
false,
6363
},
64-
{
65-
"owner address is invalid",
66-
func() {
67-
msg.Owner = "invalid_address"
68-
},
69-
false,
70-
},
7164
}
7265

7366
for i, tc := range testCases {
@@ -124,13 +117,6 @@ func TestMsgSendTxValidateBasic(t *testing.T) {
124117
},
125118
false,
126119
},
127-
{
128-
"owner address is invalid",
129-
func() {
130-
msg.Owner = "invalid_address"
131-
},
132-
false,
133-
},
134120
{
135121
"relative timeout is not set",
136122
func() {

0 commit comments

Comments
 (0)