Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip distribution if refund fails to send on channel closure #1396

Closed
3 tasks
colin-axner opened this issue May 18, 2022 · 0 comments · Fixed by #1523
Closed
3 tasks

Skip distribution if refund fails to send on channel closure #1396

colin-axner opened this issue May 18, 2022 · 0 comments · Fixed by #1523
Assignees
@chatton
Labels
29-fee
Milestone
Fee middleware RC

Comments

@colin-axner
Copy link
Contributor

Summary

This comment is incorrect. SendCoinsFromModuleToAccount can be used to send to module account addresses.

We should change SendCoins to be SendCoinsFromModuleToAccount and remove the IsBlocked check. If an error occurs, I think we should continue in the for loop and skip distribution of that address. Otherwise we block closing a channel on a faulty refund address.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega crodriguezvega moved this to Todo in ibc-go May 18, 2022
@crodriguezvega crodriguezvega added this to the Fee middleware RC milestone May 18, 2022
@charleenfei charleenfei assigned chatton and unassigned charleenfei Jun 7, 2022
@chatton chatton mentioned this issue Jun 10, 2022
Merged
9 tasks
@crodriguezvega crodriguezvega moved this from Todo to In review in ibc-go Jun 10, 2022
Repository owner moved this from In review to Done in ibc-go Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chatton chatton

Labels
29-fee
Projects
ibc-go
Archived in project
Milestone
Fee middleware RC
Development

Successfully merging a pull request may close this issue.

Skip distribution if refund fails to send on channel closure cosmos/ibc-go
4 participants
@crodriguezvega @chatton @charleenfei @colin-axner