Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce that proof height is 0 for solo machine #1874

Closed
3 tasks
colin-axner opened this issue Aug 4, 2022 · 0 comments · Fixed by #2746
Closed
3 tasks

Enforce that proof height is 0 for solo machine #1874

colin-axner opened this issue Aug 4, 2022 · 0 comments · Fixed by #2746
Assignees
@colin-axner
Labels
06-solomachine type: bug Something isn't working as expected
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

Summary

Due to addition of the generic VerifyMembership and VerifyNonMembership, the solo machine special case handling of batched verifications (ConnOpenTry and ConnOpenAck) will fail. Instead of the solo machine using the proof height to match the sequence (which is used for replay protection), the proof height should always be 0 for the solo machine and for verification it should use its latest sequence

Tests should be added which would have caught the ConnOpenTry issue

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added type: bug Something isn't working as expected 06-solomachine labels Aug 4, 2022
@colin-axner colin-axner added this to the 02-client refactor beta milestone Aug 4, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 4, 2022
@colin-axner colin-axner self-assigned this Aug 4, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Nov 1, 2022
@colin-axner colin-axner mentioned this issue Nov 14, 2022
Merged
9 tasks
@damiannolan damiannolan moved this from Todo to In review in ibc-go Nov 15, 2022
Repository owner moved this from In review to Todo in ibc-go Nov 22, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
06-solomachine type: bug Something isn't working as expected
Projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor beta
1 participant
@colin-axner