Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use commitmenttypes.MerklePath in VerifyMembership/VerifyNonMembership arguments #1884

Closed
3 tasks
colin-axner opened this issue Aug 4, 2022 · 1 comment · Fixed by #2736
Closed
3 tasks

Use commitmenttypes.MerklePath in VerifyMembership/VerifyNonMembership arguments #1884

colin-axner opened this issue Aug 4, 2022 · 1 comment · Fixed by #2736
Assignees
@damiannolan
Labels
02-client 03-connection
Milestone
02-client refacto...

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Aug 4, 2022 •
edited
Loading

Summary

In VerifyMembership and VerifyNonMembership we should use the merkle path interface instead of bytes to reduce unnecessary marshal/unmarshling. Use casting, open issue for removing path interface

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the 02-client refactor beta milestone Aug 4, 2022
@colin-axner colin-axner mentioned this issue Aug 4, 2022
Merged
9 tasks
@damiannolan
Copy link
Contributor

I think we are using []byte as this would result in an import cycle, right?

We register exported interfaces in 23-commitment/types/codec.go against the concrete types, so using MerklePath would result in an import cycle.

@crodriguezvega crodriguezvega moved this to Todo in ibc-go Aug 5, 2022
@crodriguezvega crodriguezvega moved this to Todo in ibc-go Nov 1, 2022
@colin-axner colin-axner removed the needs discussion Issues that need discussion before they can be worked on label Nov 14, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Nov 14, 2022
@damiannolan damiannolan mentioned this issue Nov 14, 2022
Merged
9 tasks
@damiannolan damiannolan moved this from In progress to In review in ibc-go Nov 14, 2022
Repository owner moved this from In review to Todo in ibc-go Nov 15, 2022
@damiannolan damiannolan moved this from Todo to Done in ibc-go Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damiannolan damiannolan

Labels
02-client 03-connection
Projects
No open projects
ibc-go
Status: Done 🥳
Milestone
02-client refactor beta
Development

Successfully merging a pull request may close this issue.

chore: updating VerifyMembership and VerifyNonMembership methods to use Path interface cosmos/ibc-go
2 participants
@damiannolan @colin-axner