Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ICS27 documentation for ibc-go/v6 #1948

Closed
3 tasks
seantking opened this issue Aug 9, 2022 · 3 comments · Fixed by #2561
Closed
3 tasks

Update ICS27 documentation for ibc-go/v6 #1948

seantking opened this issue Aug 9, 2022 · 3 comments · Fixed by #2561
Assignees
Labels
27-interchain-accounts docs Improvements or additions to documentation
Milestone

Comments

@seantking
Copy link
Contributor

seantking commented Aug 9, 2022

Summary

Update ICS27 documentation with v6 changes.

  • Document addition of ICS27 controller MsgServer
    • MsgRegisterInterchainAccount
    • MsgSendTx
    • Usage of MsgServer routing by custom application modules
  • Deprecation of Go APIs and nil underlying applications.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking self-assigned this Aug 9, 2022
@seantking seantking added the docs Improvements or additions to documentation label Aug 9, 2022
@colin-axner
Copy link
Contributor

colin-axner commented Aug 10, 2022

Could you open an issue on the spec repo as well? Also, what is the preferred way to reference the controller module within this repo when compared against a controller module

@seantking
Copy link
Contributor Author

Could you open an issue on the spec repo as well?

I don't think we reference authentication modules in the spec. I'll have a look.

Also, what is the preferred way to reference the controller module within this repo when compared against a controller module

I think we can just refer to our controller module as the "base" controller module. wdyt?

@crodriguezvega crodriguezvega moved this to In progress in ibc-go Aug 15, 2022
@crodriguezvega crodriguezvega moved this from In progress to Todo in ibc-go Aug 19, 2022
@crodriguezvega crodriguezvega added this to the v5.1.0 milestone Aug 19, 2022
@seantking seantking removed their assignment Aug 22, 2022
@seantking seantking changed the title Rename Authentication Module to Controller Module Update ICA docs after latest v5 changes Aug 22, 2022
@crodriguezvega
Copy link
Contributor

Consider opening smaller issues if there are too many things to change.

@damiannolan damiannolan changed the title Update ICA docs after latest v5 changes Update ICS27 documentation for ibc-go/v6 Oct 4, 2022
@damiannolan damiannolan self-assigned this Oct 4, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Oct 19, 2022
@colin-axner colin-axner moved this from In progress to In review in ibc-go Oct 26, 2022
@crodriguezvega crodriguezvega moved this from Backlog to In review in ibc-go Nov 1, 2022
Repository owner moved this from In review to Todo in ibc-go Nov 2, 2022
@colin-axner colin-axner moved this from Todo to Done in ibc-go Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
27-interchain-accounts docs Improvements or additions to documentation
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

4 participants