Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sdk.Msg interface for MsgSendTx #2054

Closed
3 tasks
Tracked by #2026
damiannolan opened this issue Aug 19, 2022 · 0 comments · Fixed by #2135
Closed
3 tasks
Tracked by #2026

Implement sdk.Msg interface for MsgSendTx #2054

damiannolan opened this issue Aug 19, 2022 · 0 comments · Fixed by #2135
Assignees
@charleenfei
Labels
27-interchain-accounts
Milestone
v6.0.0

Comments

@damiannolan
Copy link
Member

Summary

Implement the sdk.Msg interface for the new MsgSendTx type with associated test cases.

  • ValidateBasic() error
  • GetSigners() []sdk.AccAddress

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the v5.1.0 milestone Aug 19, 2022
@damiannolan damiannolan mentioned this issue Aug 19, 2022
Closed
11 tasks
@damiannolan damiannolan moved this to Todo in ibc-go Aug 19, 2022
@charleenfei charleenfei self-assigned this Aug 23, 2022
@charleenfei charleenfei moved this from Todo to In progress in ibc-go Aug 23, 2022
@charleenfei charleenfei mentioned this issue Aug 26, 2022
Merged
9 tasks
@charleenfei charleenfei moved this from In progress to In review in ibc-go Aug 26, 2022
Repository owner moved this from In review to Done in ibc-go Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charleenfei charleenfei

Labels
27-interchain-accounts
Projects
ibc-go
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

chore: adding sdk.Msg impl for ics27 MsgSubmitTx cosmos/ibc-go
2 participants
@damiannolan @charleenfei