Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gRPC for 02-client params #2119

Closed
3 tasks
colin-axner opened this issue Aug 25, 2022 · 2 comments · Fixed by #2573
Closed
3 tasks

Add gRPC for 02-client params #2119

colin-axner opened this issue Aug 25, 2022 · 2 comments · Fixed by #2573
Assignees
@crodriguezvega
Labels
02-client
Milestone
v6.0.0

Comments

@colin-axner
Copy link
Contributor

Summary

Same as #2066 but for 02-client params

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@seantking seantking assigned seantking and unassigned seantking Aug 30, 2022
@crodriguezvega
Copy link
Contributor

I think this is already implemented.

@colin-axner
Copy link
Contributor Author

Yup, but I think we could rename to params to be consistent

@crodriguezvega crodriguezvega moved this to Backlog in ibc-go Oct 17, 2022
@crodriguezvega crodriguezvega moved this from Backlog to Todo in ibc-go Oct 24, 2022
@crodriguezvega crodriguezvega self-assigned this Oct 24, 2022
@crodriguezvega crodriguezvega added this to the v6.0.0 milestone Oct 24, 2022
@crodriguezvega crodriguezvega linked a pull request Oct 24, 2022 that will close this issue
rename ClientParams gRPC method to Params #2573
Merged
9 tasks
@crodriguezvega crodriguezvega mentioned this issue Oct 24, 2022
Merged
9 tasks
@colin-axner colin-axner moved this from Todo to In review in ibc-go Oct 25, 2022
Repository owner moved this from In review to Done in ibc-go Oct 28, 2022
@crodriguezvega crodriguezvega moved this from Todo to Done in ibc-go Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crodriguezvega crodriguezvega

Labels
02-client
Projects
ibc-go
Archived in project
Milestone
v6.0.0
Development

Successfully merging a pull request may close this issue.

rename ClientParams gRPC method to Params cosmos/ibc-go
3 participants
@crodriguezvega @seantking @colin-axner