Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce calls to ics27 message server to not route through underlying app callbacks in ics27 controller #2145

Closed
3 tasks
colin-axner opened this issue Aug 30, 2022 · 0 comments · Fixed by #2157
Assignees
Milestone

Comments

@colin-axner
Copy link
Contributor

Summary

Legacy calls to SendTx and RegisterInterchainAccount should route through the underlying app, while calls to the message server should not

Problem Definition

Calls through the message server may not want the underlying app to handle their packet (the underlying app did not send the packet nor register the account).

Proposal

Add a mapping which sets a flag ([]byte(1) similar to core IBC receipt)) if the underlying app is created with the legacy API or the new API. A new registerInterchainAccount function has been added, so this can be extended with a boolean

Every call to the underlying app should be associated with a lookup to whether the channel should use the underlying app or not

This is backwards compatible (previous functionality remains unchanged) and can be removed in the future when we remove the underlying app from ics27 controller


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added this to the v5.1.0 milestone Aug 30, 2022
@damiannolan damiannolan self-assigned this Aug 31, 2022
@colin-axner colin-axner moved this to In review in ibc-go Aug 31, 2022
Repository owner moved this from In review to Done in ibc-go Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants