-
Notifications
You must be signed in to change notification settings - Fork 608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove duplicate imports #2185
Conversation
@@ -18,7 +16,7 @@ import ( | |||
|
|||
func (suite *KeeperTestSuite) TestRegisterAccount() { | |||
var ( | |||
msg *controllertypes.MsgRegisterAccount | |||
msg *types.MsgRegisterAccount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we have icatypes
, clienttypes
channeltypes
etc. does it make sense to have a package imported as just types
? It's not immediately obvious which sort of types it is, I would lean in favour of keeping it called controllertypes
and removing the unaliased one WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a lot of other packages we normally import the relative types
pkg as is, and then for any types
pkgs from other modules we alias them.
I don't really feel strongly about it here. It's also a test file so.. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For interchain accounts it may help to always alias tho. Considering there is the shared icatypes
and then a separate types
for both controller and host submodules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see okay, so we generally just do external types with the alias, that seems fine with me 👍
Description
msg_server_test.go
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes