Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Run icad upgrade test with ICS27 migrations #2188

Closed
3 tasks
damiannolan opened this issue Sep 5, 2022 · 0 comments · Fixed by #2490
Closed
3 tasks

E2E: Run icad upgrade test with ICS27 migrations #2188

damiannolan opened this issue Sep 5, 2022 · 0 comments · Fixed by #2490

Comments

@damiannolan
Copy link
Member

damiannolan commented Sep 5, 2022

Summary

An e2e test should be added for verifying upgrade migrations run successfully for ICS27 channel capabilities.
This includes both the manual upgrade handler and automatic migration code path run via consensus version bump.

The goal of the test should be to successfully migrate ownership of the ICS27 channel capability from intertx to the controller submodule, and ensure the channel continues to operate without issues.
The high level flow of the e2e should be as follows:

  1. Create an ICS27 channel using an existing auth module. E.g. intertx
  2. Verify SendTx behaves as expected
  3. Create software upgrade proposal
  4. Execute proposal and upgrade to new chain binary
  5. Migrations are run via upgrade handler and automatic migrations via consensus version increment.
  6. Verify SendTx behaves as expected

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@damiannolan damiannolan added this to the v5.1.0 milestone Sep 5, 2022
@damiannolan damiannolan moved this to Todo in ibc-go Sep 5, 2022
@damiannolan damiannolan moved this from Todo to On hold in ibc-go Sep 5, 2022
@crodriguezvega crodriguezvega moved this from On hold to Todo in ibc-go Oct 3, 2022
@damiannolan damiannolan moved this from Todo to In progress in ibc-go Oct 6, 2022
@damiannolan damiannolan self-assigned this Oct 6, 2022
@damiannolan damiannolan moved this from In progress to In review in ibc-go Oct 13, 2022
@crodriguezvega crodriguezvega moved this from Backlog to In review in ibc-go Nov 1, 2022
Repository owner moved this from In review to Todo in ibc-go Nov 2, 2022
@colin-axner colin-axner moved this from Todo to Done in ibc-go Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🥳
Development

Successfully merging a pull request may close this issue.

1 participant