chore: rename SubmitTx to SendTx
#2255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
approved these changes
Sep 9, 2022
| @@ -77,10 +77,10 @@ the associated capability.`), | |||
| return cmd | |||
| } | |||
|
|
|||
| func newSubmitTxCmd() *cobra.Command { | |||
| func newSendTxCmd() *cobra.Command { | |||
There was a problem hiding this comment.
Sorry, this is probably a bit nitpicking, but I was just thinking that what we send to the host chain is a message, right? Or is message and transaction something that mean the same thing? For me I thought that a transaction was the execution of the message, but maybe I am just mistaken... Saying this because maybe this could be renamed to SendMsg...
There was a problem hiding this comment.
I think we should just stick with the naming used in the spec. I see your reasoning but the InterchainAccountPacketData type may be composed of one or many sdk.Msgs encoded into the []byte field.
| @@ -25,15 +25,15 @@ func NewMsgServerImpl(keeper *Keeper) types.MsgServer { | |||
| } | |||
|
|
|||
| // RegisterAccount defines a rpc handler for MsgRegisterAccount | |||
| func (k msgServer) RegisterAccount(goCtx context.Context, msg *types.MsgRegisterAccount) (*types.MsgRegisterAccountResponse, error) { | |||
| func (s msgServer) RegisterAccount(goCtx context.Context, msg *types.MsgRegisterAccount) (*types.MsgRegisterAccountResponse, error) { | |||
There was a problem hiding this comment.
Ah, nice I see that you're renaming it here now... So forget about my comment here.
damiannolan
requested review from
seantking,
colin-axner,
AdityaSripal,
charleenfei and
chatton
as code owners
mergify bot
pushed a commit
that referenced
this pull request
Sep 9, 2022
* updating naming of submit tx to send tx * use struct embedding (cherry picked from commit a4be561) # Conflicts: # docs/ibc/proto-docs.md # modules/apps/27-interchain-accounts/controller/client/cli/cli.go # modules/apps/27-interchain-accounts/controller/keeper/msg_server.go # modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go # modules/apps/27-interchain-accounts/controller/types/codec.go # modules/apps/27-interchain-accounts/controller/types/tx.pb.go # proto/ibc/applications/interchain_accounts/controller/v1/tx.proto
9 tasks
crodriguezvega
added a commit
that referenced
this pull request
Sep 16, 2022
* chore: rename `SubmitTx` to `SendTx` (#2255) * updating naming of submit tx to send tx * use struct embedding (cherry picked from commit a4be561) # Conflicts: # docs/ibc/proto-docs.md # modules/apps/27-interchain-accounts/controller/client/cli/cli.go # modules/apps/27-interchain-accounts/controller/keeper/msg_server.go # modules/apps/27-interchain-accounts/controller/keeper/msg_server_test.go # modules/apps/27-interchain-accounts/controller/types/codec.go # modules/apps/27-interchain-accounts/controller/types/tx.pb.go # proto/ibc/applications/interchain_accounts/controller/v1/tx.proto * fix conflicts * chore: fixing test failures Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: crodriguezvega <carlos@interchain.io> Co-authored-by: Cian Hatton <cianhatton@gmail.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SubmitTxrpc toSendTxmsgServercloses: #2231
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes